Skip to content

Conversation

guybedford
Copy link
Contributor

This updates to [email protected], with the following patches:

Both are for Babel reexports patterns, backports will be necessary for compat.

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 30, 2021
@guybedford
Copy link
Contributor Author

@nodejs/modules

@guybedford guybedford force-pushed the cjs-module-lexer-update branch from 320e58f to 8706fb8 Compare March 30, 2021 18:51
@guybedford guybedford force-pushed the cjs-module-lexer-update branch from 8706fb8 to c97633b Compare March 30, 2021 18:56
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

guybedford added a commit that referenced this pull request Apr 1, 2021
PR-URL: #37992
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@guybedford
Copy link
Contributor Author

Landed in 0d66317.

@guybedford guybedford closed this Apr 1, 2021
MylesBorins pushed a commit that referenced this pull request Apr 4, 2021
PR-URL: #37992
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 4, 2021
guybedford added a commit that referenced this pull request Apr 14, 2021
PR-URL: #38002
Backport-PR-URL: #37992
Reviewed-By: Jan Krems <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 23, 2021
PR-URL: #37992
Backport-PR-URL: #38003
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@richardlau richardlau mentioned this pull request Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants