Skip to content

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 26, 2021

When I moved node-inspect into core, I called a lot of things
inspector-cli that really should have been debugger. This is the
last of them to be renamed.

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 26, 2021
@github-actions github-actions bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jun 26, 2021
@nodejs-github-bot
Copy link
Collaborator

When I moved node-inspect into core, I called a lot of things
`inspector-cli` that really should have been `debugger`. This is the
last of them to be renamed.

PR-URL: nodejs#39156
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@Trott
Copy link
Member Author

Trott commented Jun 28, 2021

Landed in 9cdac42

@Trott Trott merged commit 9cdac42 into nodejs:master Jun 28, 2021
@Trott Trott deleted the finally branch June 28, 2021 13:28
targos pushed a commit that referenced this pull request Jul 11, 2021
When I moved node-inspect into core, I called a lot of things
`inspector-cli` that really should have been `debugger`. This is the
last of them to be renamed.

PR-URL: #39156
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request Sep 4, 2021
When I moved node-inspect into core, I called a lot of things
`inspector-cli` that really should have been `debugger`. This is the
last of them to be renamed.

PR-URL: #39156
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants