doc,meta: update email addresses for misterdjules #39433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
jasnell
approved these changes
Jul 19, 2021
lpinca
approved these changes
Jul 19, 2021
Julien Gilli appears twice with two email addresses in the current AUTHORS file. Use .mailmap to map one to the other (keeping the most recent one). Also update email in the README from a (I believe invalid, since it is not listed in the email repo aliases.json file) nodejs.org email to the email they more recently committed with. Finally, re-run `update-authors.js` so they only have one entry in AUTHORS. PR-URL: nodejs#39433 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
Landed in 5100c3c |
targos
pushed a commit
that referenced
this pull request
Jul 21, 2021
Julien Gilli appears twice with two email addresses in the current AUTHORS file. Use .mailmap to map one to the other (keeping the most recent one). Also update email in the README from a (I believe invalid, since it is not listed in the email repo aliases.json file) nodejs.org email to the email they more recently committed with. Finally, re-run `update-authors.js` so they only have one entry in AUTHORS. PR-URL: #39433 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
|
Thank you @Trott, and sorry I didn't notice this PR until now. |
richardlau
pushed a commit
that referenced
this pull request
Jul 29, 2021
Julien Gilli appears twice with two email addresses in the current AUTHORS file. Use .mailmap to map one to the other (keeping the most recent one). Also update email in the README from a (I believe invalid, since it is not listed in the email repo aliases.json file) nodejs.org email to the email they more recently committed with. Finally, re-run `update-authors.js` so they only have one entry in AUTHORS. PR-URL: #39433 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Jul 29, 2021
Julien Gilli appears twice with two email addresses in the current AUTHORS file. Use .mailmap to map one to the other (keeping the most recent one). Also update email in the README from a (I believe invalid, since it is not listed in the email repo aliases.json file) nodejs.org email to the email they more recently committed with. Finally, re-run `update-authors.js` so they only have one entry in AUTHORS. PR-URL: #39433 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 4, 2021
Julien Gilli appears twice with two email addresses in the current AUTHORS file. Use .mailmap to map one to the other (keeping the most recent one). Also update email in the README from a (I believe invalid, since it is not listed in the email repo aliases.json file) nodejs.org email to the email they more recently committed with. Finally, re-run `update-authors.js` so they only have one entry in AUTHORS. PR-URL: #39433 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Julien Gilli appears twice with two email addresses in the current
AUTHORS file. Use .mailmap to map one to the other (keeping the most
recent one). Also update email in the README from a (I believe invalid,
since it is not listed in the email repo aliases.json file) nodejs.org
email to the email they more recently committed with. Finally, re-run
update-authors.jsso they only have one entry in AUTHORS.