doc(async-hooks): correct cjs code to match mjs code #39509
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
async_hooks
rluvaton
changed the title
tniessen
approved these changes
Jul 25, 2021
HarshithaKP
approved these changes
Jul 25, 2021
jasnell
approved these changes
Jul 26, 2021
lpinca
approved these changes
Jul 26, 2021
vdeturckheim
approved these changes
Jul 27, 2021
|
How many reviewers need to approve before a PR can be merged? 😀 |
|
Landed in e087d78. |
lpinca
pushed a commit
that referenced
this pull request
Aug 16, 2021
PR-URL: #39509 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vladimir de Turckheim <[email protected]>
|
Thank you @lpinca |
|
That's how PRs are merged in Node.js core. See https://github.com/nodejs/node/blob/966060df0e4aa7d79bfdd9fe2163b12298cf59b7/doc/guides/collaborator-guide.md#landing-pull-requests. |
danielleadams
pushed a commit
that referenced
this pull request
Aug 16, 2021
PR-URL: #39509 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vladimir de Turckheim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.