[v12.x] http2: patch double-free error due to handling of rst_stream #39527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlau
changed the title
|
cc @nodejs/http2 |
richardlau
added
the
fast-track
guybedford
force-pushed
the
v12.x-staging
branch
from
632a3ae to
1b7af5b
Compare
richardlau
approved these changes
Jul 26, 2021
richardlau
force-pushed
the
kumarak/v12.x-stagging-build-error
branch
from
f80771d to
ba2ac7b
Compare
|
Rebased as v12.x-staging was force-pushed. |
BethGriggs
approved these changes
Jul 26, 2021
github-actions
bot
added
c++
richardlau
pushed a commit
that referenced
this pull request
Jul 27, 2021
PR-URL: #39423 Backport-PR-URL: #39527 Fixes: #38964 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Jul 27, 2021
PR-URL: #39423 Backport-PR-URL: #39527 Fixes: #38964 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
|
Landed in e47d2d2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR patches the double-free error due to handling of
RST_STREAMframe with cancel code.The previous PR(#39423) causes build failure with
v12.x-stagingbranch since the interfaces to check thesession flags changes. The changes backport APIs to
check the status flag of
Http2Sessionas well.Ref: #39423
Fixes: #38964