test: fix test-debugger-heap-profiler for workers #39687
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix `sequential/test-debugger-heap-profiler` so that it can be run in a worker thread. `process.chdir()` is not allowed in worker threads but passing a current working directory into a spawned child process is allowed.
nodejs-github-bot
added
needs-ci
github-actions
bot
removed
the
request-ci
Trott
approved these changes
Aug 6, 2021
cjihrig
approved these changes
Aug 6, 2021
richardlau
added
the
author ready
jasnell
approved these changes
Aug 7, 2021
richardlau
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in 6145113...602fe4e |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Aug 9, 2021
Fix `sequential/test-debugger-heap-profiler` so that it can be run in a worker thread. `process.chdir()` is not allowed in worker threads but passing a current working directory into a spawned child process is allowed. PR-URL: #39687 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Aug 16, 2021
Fix `sequential/test-debugger-heap-profiler` so that it can be run in a worker thread. `process.chdir()` is not allowed in worker threads but passing a current working directory into a spawned child process is allowed. PR-URL: #39687 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 4, 2021
Fix `sequential/test-debugger-heap-profiler` so that it can be run in a worker thread. `process.chdir()` is not allowed in worker threads but passing a current working directory into a spawned child process is allowed. PR-URL: #39687 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
sequential/test-debugger-heap-profilerso that it can be runin a worker thread.
process.chdir()is not allowed in worker threadsbut passing a current working directory into a spawned child process
is allowed.