Skip to content

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Aug 6, 2021

We already set --max-old-space-size=8192 for Windows.

Fixes #39445

@bcoe bcoe requested a review from targos August 6, 2021 21:47
@bcoe bcoe added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 6, 2021
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Aug 6, 2021
@bcoe bcoe added fast-track PRs that do not need to wait for 48 hours to land. and removed meta Issues and PRs related to the general management of the project. labels Aug 6, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2021

Fast-track has been requested by @bcoe. Please 👍 to approve.

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 7, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 7, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2021

Landed in 822f9ff...5a01efd

@github-actions github-actions bot closed this Aug 7, 2021
nodejs-github-bot pushed a commit that referenced this pull request Aug 7, 2021
PR-URL: #39690
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Aug 16, 2021
PR-URL: #39690
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

coverage-linux workflow going out of memory

6 participants