Skip to content

Conversation

mhdawson
Copy link
Member

Add missing initialization reported by coverity scan.

Signed-off-by: Michael Dawson [email protected]

Add missing initialization reported by coverity scan.

Signed-off-by: Michael Dawson <[email protected]>
@mhdawson mhdawson requested a review from jasnell October 21, 2021 20:58
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Oct 21, 2021
@mhdawson
Copy link
Member Author

@jasnell I think moving the env_ makes sense but hoping you can easily confirm/correct.

Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasnell I think moving the env_ makes sense but hoping you can easily confirm/correct.

@mhdawson Moving a pointer doesn’t do anything (except maybe look odd).

Signed-off-by: Michael Dawson <[email protected]>
@mhdawson
Copy link
Member Author

@addaleax thanks, pushed a commit to remove the move.

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@tniessen
Copy link
Member

tniessen commented Nov 2, 2021

Nit: typo in commit message

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

mhdawson added a commit that referenced this pull request Nov 12, 2021
Add missing initialization reported by coverity scan.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #40555
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@mhdawson
Copy link
Member Author

Landed in 055a38b4c7db64ab1461cd44b7605d5b020ab382

@mhdawson mhdawson closed this Nov 12, 2021
targos pushed a commit that referenced this pull request Nov 21, 2021
Add missing initialization reported by coverity scan.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #40555
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
Add missing initialization reported by coverity scan.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #40555
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
Add missing initialization reported by coverity scan.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #40555
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants