Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions lib/internal/policy/manifest.js
Original file line number Diff line number Diff line change
Expand Up @@ -136,9 +136,8 @@ class DependencyMapperInstance {
if (!target) {
throw new ERR_MANIFEST_INVALID_SPECIFIER(
this.href,
target +
', pattern needs to have a single' +
'trailing "*" in target');
`${target}, pattern needs to have a single trailing "*" in target`
);
}
const prefix = target[1];
const suffix = target[2];
Expand Down
9 changes: 9 additions & 0 deletions test/fixtures/policy-manifest/invalid.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"resources": {
"./fhqwhgads.js": {
"dependencies": {
"**": true
}
}
}
}
25 changes: 25 additions & 0 deletions test/parallel/test-policy-manifest.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
'use strict';

const common = require('../common');

if (!common.hasCrypto)
common.skip('missing crypto');

common.requireNoPackageJSONAbove();

const assert = require('assert');
const { spawnSync } = require('child_process');
const fixtures = require('../common/fixtures.js');

const policyFilepath = fixtures.path('policy-manifest', 'invalid.json');

const result = spawnSync(process.execPath, [
'--experimental-policy',
policyFilepath,
'./fhqwhgads.js',
]);

assert.notStrictEqual(result.status, 0);
const stderr = result.stderr.toString();
assert.match(stderr, /ERR_MANIFEST_INVALID_SPECIFIER/);
assert.match(stderr, /pattern needs to have a single trailing "\*"/);