Skip to content

test: fix test-datetime-change-notify after daylight change #40670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

test: fix test-datetime-change-notify after daylight change #40670

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/parallel/test-datetime-change-notify.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const cases = [
},
{
timeZone: 'Europe/Dublin',
expected: /Irish/,
expected: /(Irish Standard Time|Greenwich Mean Time)/,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably best to avoid unnecessary groups:

Suggested change
expected: /(Irish Standard Time|Greenwich Mean Time)/,
expected: /Irish Standard Time|Greenwich Mean Time/,

},
];

Expand Down