node-api: add missing initialization of last error #41290
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add missing initiatlization of last error which was reported by coverity. Signed-off-by: Michael Dawson <[email protected]>
|
Review requested:
|
nodejs-github-bot
added
c++
lpinca
approved these changes
Dec 23, 2021
github-actions
bot
removed
the
request-ci
18 tasks
tniessen
approved these changes
Dec 24, 2021
jasnell
approved these changes
Dec 24, 2021
This was referenced Dec 25, 2021
JungMinu
approved these changes
Dec 30, 2021
This was referenced Dec 31, 2021
|
Looks like CI is complete even though UI still shows one check as pending, going to land. |
mhdawson
added a commit
that referenced
this pull request
Jan 4, 2022
- Add missing initiatlization of last error which was reported by coverity. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #41290 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
|
Landed in 3f403e5 |
This was referenced Jan 5, 2022
18 tasks
targos
pushed a commit
that referenced
this pull request
Jan 14, 2022
- Add missing initiatlization of last error which was reported by coverity. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #41290 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
- Add missing initiatlization of last error which was reported by coverity. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #41290 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
- Add missing initiatlization of last error which was reported by coverity. Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#41290 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
- Add missing initiatlization of last error which was reported by coverity. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #41290 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
was reported by coverity.
Signed-off-by: Michael Dawson [email protected]