fix: uncaught exception on domain #41546
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
domain
MrJithil
force-pushed
the
fix-40999
branch
3 times, most recently
from
bf87573 to
d3720c7
Compare
|
This seems like something that would silence the issue and avoid the exception, but not address the underlying problem. |
fix uncaught exception on domain Fixes: nodejs#40999
Yes, it will fix the uncaught exception by adding missing null checks. |
|
Instead of fixing a doc-deprecated module, shouldn't we find a way to help the reporter migrate to a different solution? |
|
Closing the MR since no active conversations post 13 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: uncaught exception on domain
Fixes: #40999
Derives from tag: v3.0.0 + 23399 commits