Skip to content

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 8, 2015

No description provided.

@Trott Trott added child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. labels Dec 8, 2015
@targos
Copy link
Member

targos commented Dec 8, 2015

LGTM

1 similar comment
@JungMinu
Copy link
Member

JungMinu commented Dec 8, 2015

LGTM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe write out process identifier? I'm not a fan of ID as it isn't even an abbreviation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree; I'll write it out as identifier.

Trott added a commit that referenced this pull request Dec 10, 2015
PR-URL: #4188
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@Trott
Copy link
Member Author

Trott commented Dec 10, 2015

Landed in 37ed05b

@Trott Trott closed this Dec 10, 2015
Trott added a commit that referenced this pull request Dec 15, 2015
PR-URL: #4188
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@rvagg rvagg mentioned this pull request Dec 17, 2015
Trott added a commit that referenced this pull request Dec 29, 2015
PR-URL: #4188
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
PR-URL: #4188
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
PR-URL: nodejs#4188
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@Trott Trott deleted the child_process branch January 13, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants