Skip to content

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Mar 11, 2022

Backport of #41310 and #42268.

@aduh95 aduh95 added the semver-minor PRs that contain new features and should be released in the next minor version. label Mar 11, 2022
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem. v16.x labels Mar 11, 2022
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aduh95 aduh95 force-pushed the net-socket-options-v16.x branch from e1c7592 to 5e48375 Compare March 12, 2022 00:00
@danielleadams
Copy link
Contributor

@aduh95 can you rebase this?

ShogunPanda and others added 2 commits April 10, 2022 13:31
PR-URL: nodejs#41310
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Refs: nodejs#41310

PR-URL: nodejs#42268
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@aduh95 aduh95 force-pushed the net-socket-options-v16.x branch from 5e48375 to ce4a7e1 Compare April 10, 2022 11:31
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@danielleadams
Copy link
Contributor

Landed in 85e3624...f8819e8

danielleadams pushed a commit that referenced this pull request Apr 11, 2022
PR-URL: #41310
Backport-PR-URL: #42298
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Apr 11, 2022
Refs: #41310

PR-URL: #42268
Backport-PR-URL: #42298
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@aduh95 aduh95 deleted the net-socket-options-v16.x branch April 11, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants