child_process: add env contents types in JSDoc #42494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
child_process
Mesteery
reviewed
Mar 27, 2022
Use JSDoc to indicate that the `env` object keys and values must be strings. Refs: nodejs#42489 (comment)
benjamingr
approved these changes
Mar 28, 2022
aduh95
approved these changes
Mar 28, 2022
Trott
added
commit-queue
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Trott
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in f8ca5df |
9 tasks
juanarbol
pushed a commit
that referenced
this pull request
Apr 4, 2022
Use JSDoc to indicate that the `env` object keys and values must be strings. Refs: #42489 (comment) PR-URL: #42494 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
juanarbol
pushed a commit
to juanarbol/node
that referenced
this pull request
Apr 5, 2022
Use JSDoc to indicate that the `env` object keys and values must be strings. Refs: nodejs#42489 (comment) PR-URL: nodejs#42494 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
juanarbol
pushed a commit
that referenced
this pull request
Apr 6, 2022
Use JSDoc to indicate that the `env` object keys and values must be strings. Refs: #42489 (comment) PR-URL: #42494 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
xtx1130
pushed a commit
to xtx1130/node
that referenced
this pull request
Apr 25, 2022
Use JSDoc to indicate that the `env` object keys and values must be strings. Refs: nodejs#42489 (comment) PR-URL: nodejs#42494 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
Use JSDoc to indicate that the `env` object keys and values must be strings. Refs: #42489 (comment) PR-URL: #42494 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jun 27, 2022
Use JSDoc to indicate that the `env` object keys and values must be strings. Refs: #42489 (comment) PR-URL: #42494 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 11, 2022
Use JSDoc to indicate that the `env` object keys and values must be strings. Refs: #42489 (comment) PR-URL: #42494 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 11, 2022
Use JSDoc to indicate that the `env` object keys and values must be strings. Refs: #42489 (comment) PR-URL: #42494 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
Use JSDoc to indicate that the `env` object keys and values must be strings. Refs: #42489 (comment) PR-URL: #42494 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
Use JSDoc to indicate that the `env` object keys and values must be strings. Refs: nodejs/node#42489 (comment) PR-URL: nodejs/node#42494 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use JSDoc to indicate that the
envobject keys and values must bestrings.
Refs: #42489 (comment)