Skip to content

esm: add chaining to loaders #42623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
May 4, 2022
Merged

esm: add chaining to loaders #42623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
8005915
esm: add chaining to loaders
JakobJingleheimer Apr 30, 2022
1ad975b
fix: --experimental-loader is an array
targos Apr 30, 2022
3f4dfab
fixup: add breaking change warning to ESM loaders section
JakobJingleheimer May 1, 2022
fa0cf39
fixup: doc `userLoaders` within `shouldUseESMLoader()`
JakobJingleheimer May 1, 2022
7d6b80b
fixup: tidy tests
JakobJingleheimer May 1, 2022
8cc538d
fixup: tidy node internal paths for default hooks
JakobJingleheimer May 1, 2022
a20dc14
fixup: restore `emittedSpecifierResolutionWarning`
JakobJingleheimer May 1, 2022
06803f1
fixup: doc ESMLoader hook methods
JakobJingleheimer May 1, 2022
db4f4ee
fixup: use correct JSDoc tag
GeoffreyBooth May 2, 2022
7588a2f
fixup: tidy code styles & clarify var names (#1)
GeoffreyBooth May 2, 2022
859fd88
fixup: `next` → `nextResolve` & `nextLoad`
JakobJingleheimer May 2, 2022
cea5473
fixup: account for nested hook short-circuiting
JakobJingleheimer May 2, 2022
b56112f
fixup: optimise loadNext's internal validity check on `url`
JakobJingleheimer May 2, 2022
7cc33e4
fixup: tidy ESM doc & add changelog info
JakobJingleheimer May 3, 2022
6bb5359
fixup: update internals for `next()` → `next<hookName>()`
JakobJingleheimer May 3, 2022
9fc7ba5
fixup: `fixtures.path()` → `fixtures.fileURL()`
JakobJingleheimer May 3, 2022
1c712e9
fixup: code doc for ESMLoader::import() … namespaces
JakobJingleheimer May 3, 2022
21bd600
fixup: update manual anchor links
JakobJingleheimer May 3, 2022
c81ad32
fixup: tweak ESM doc `resolve` & `load` hooks' changelogs
JakobJingleheimer May 3, 2022
96acd20
fixup: wordsmith ESM hooks' changelogs
JakobJingleheimer May 3, 2022
4169efb
fixup: remove extra whitespace character
JakobJingleheimer May 3, 2022
15eecb6
fixup: wordsmith ESM warning for triggering chaining exceptions
JakobJingleheimer May 3, 2022
6dd23ee
fixup: optimise resolve's validity check on `url`
JakobJingleheimer May 4, 2022
38e596b
fixup: test fixture `node:` → `import.meta.url`
JakobJingleheimer May 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions doc/api/errors.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2092,6 +2092,17 @@ An attempt was made to open an IPC communication channel with a synchronously
forked Node.js process. See the documentation for the [`child_process`][] module
for more information.

<a id="ERR_LOADER_CHAIN_INCOMPLETE"></a>

### `ERR_LOADER_CHAIN_INCOMPLETE`

<!-- YAML
added: REPLACEME
-->

An ESM loader hook returned without calling `next()` and without explicitly
signaling a short circuit.

<a id="ERR_MANIFEST_ASSERT_INTEGRITY"></a>

### `ERR_MANIFEST_ASSERT_INTEGRITY`
Expand Down
Loading