Skip to content

Conversation

panva
Copy link
Member

@panva panva commented Jun 2, 2022

v18.3.0 release did not update the CHANGELOG_V18.md table. This makes the GitHub Action
linters workflow lint-js-and-md job fail due to 18.3.0 being an unrecognized version.

https://github.com/nodejs/node/actions/workflows/linters.yml

@panva panva added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 2, 2022
@nodejs-github-bot nodejs-github-bot added the release Issues and PRs related to Node.js releases. label Jun 2, 2022
@panva panva added doc Issues and PRs related to the documentations. and removed release Issues and PRs related to Node.js releases. labels Jun 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2022

Fast-track has been requested by @panva. Please 👍 to approve.

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 2, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 2, 2022
@nodejs-github-bot nodejs-github-bot merged commit 5ce141c into nodejs:master Jun 2, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 5ce141c

@panva panva deleted the fix-18-changelog branch June 2, 2022 12:43
italojs pushed a commit to italojs/node that referenced this pull request Jun 6, 2022
PR-URL: nodejs#43298
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
danielleadams pushed a commit that referenced this pull request Jun 11, 2022
PR-URL: #43298
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@danielleadams danielleadams mentioned this pull request Jun 11, 2022
danielleadams pushed a commit that referenced this pull request Jun 13, 2022
PR-URL: #43298
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants