Skip to content

test: add logs to watch-mode-inspect #44861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2022
Merged

test: add logs to watch-mode-inspect #44861

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions test/sequential/test-watch-mode-inspect.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ if (common.isIBMi)
common.skipIfInspectorDisabled();

describe('watch mode - inspect', () => {
const silentLogger = { log: () => {}, error: () => {} };
async function getDebuggedPid(instance, waitForLog = true) {
const session = await instance.connectInspectorSession();
await session.send({ method: 'Runtime.enable' });
Expand All @@ -28,7 +27,7 @@ describe('watch mode - inspect', () => {

it('should start debugger on inner process', async () => {
const file = fixtures.path('watch-mode/inspect.js');
const instance = new NodeInstance(['--inspect=0', '--watch'], undefined, file, silentLogger);
const instance = new NodeInstance(['--inspect=0', '--watch'], undefined, file);
let stderr = '';
instance.on('stderr', (data) => { stderr += data; });

Expand All @@ -48,7 +47,7 @@ describe('watch mode - inspect', () => {

it('should prevent attaching debugger with SIGUSR1 to outer process', { skip: common.isWindows }, async () => {
const file = fixtures.path('watch-mode/inspect_with_signal.js');
const instance = new NodeInstance(['--inspect-port=0', '--watch'], undefined, file, silentLogger);
const instance = new NodeInstance(['--inspect-port=0', '--watch'], undefined, file);
let stderr = '';
instance.on('stderr', (data) => { stderr += data; });

Expand Down