Skip to content

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Feb 18, 2023

as written here, this pr includes some earlier commits it depends on

@MoLow MoLow requested a review from MylesBorins February 18, 2023 21:48
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v19.x labels Feb 18, 2023
@MoLow MoLow force-pushed the v19-backport-test-runner-flatten-tap branch from 5b64b4b to 1f19c4b Compare February 19, 2023 06:41
PR-URL: nodejs#46440
Fixes: nodejs#45833
Refs: nodejs#45833
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@MoLow MoLow force-pushed the v19-backport-test-runner-flatten-tap branch from 1f19c4b to 01b9515 Compare February 25, 2023 21:08
@MoLow
Copy link
Member Author

MoLow commented Feb 25, 2023

CC @nodejs/backporters @nodejs/releasers I have made sure all other test runner related PR's land clearly on top of this

@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 25, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 25, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@targos
Copy link
Member

targos commented Mar 13, 2023

The original commit landed cleanly in the end

@targos targos closed this Mar 13, 2023
@MoLow
Copy link
Member Author

MoLow commented Mar 13, 2023

thanks

@MoLow MoLow deleted the v19-backport-test-runner-flatten-tap branch March 13, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants