Skip to content

tools: replace sre_compile with re.compile #47005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

tools: replace sre_compile with re.compile #47005

wants to merge 1 commit into from

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Mar 8, 2023 •
edited
Loading

No description provided.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Mar 8, 2023
@MoLow
Copy link
Member Author

MoLow commented Mar 8, 2023

CC @nodejs/python

@richardlau
Copy link
Member

FWIW this has also been proposed upstream: cpplint/cpplint#214

@MoLow MoLow closed this Mar 8, 2023
@MoLow MoLow deleted the fix-sre-compile-deprecation branch March 8, 2023 01:21
@targos targos mentioned this pull request Sep 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MoLow @richardlau @nodejs-github-bot