Skip to content

test: fix WPT state when process exits but workers are still running #47826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2023
Merged

test: fix WPT state when process exits but workers are still running #47826

merged 1 commit into from
May 3, 2023

Conversation

panva
Copy link
Member

@panva panva commented May 2, 2023

Because inProgress is now a Set<WPTTestSpec>.

Refs: #47821 (comment)

@panva panva added test Issues and PRs related to the tests. fast-track PRs that do not need to wait for 48 hours to land. labels May 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

Fast-track has been requested by @panva. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label May 2, 2023
@panva panva mentioned this pull request May 2, 2023
Merged
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label May 2, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 2, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51586/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51587/

@github-actions github-actions bot mentioned this pull request May 3, 2023
Open
33 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51589/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51592/

@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label May 3, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 3, 2023
@nodejs-github-bot nodejs-github-bot merged commit e623e1a into nodejs:main May 3, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in e623e1a

This was referenced May 4, 2023
Open
Open
Open
targos pushed a commit that referenced this pull request May 12, 2023
@panva @targos
test: fix WPT state when process exits but workers are still running
c923367 
PR-URL: #47826
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@targos targos mentioned this pull request May 15, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@panva @danielleadams
test: fix WPT state when process exits but workers are still running
0e4aa46 
PR-URL: #47826
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@panva @MoLow
test: fix WPT state when process exits but workers are still running
f1e1312 
PR-URL: nodejs#47826
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
@panva panva deleted the wpt-fix-unknown-error branch August 22, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@MoLow MoLow MoLow approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@panva @nodejs-github-bot @anonrig @MoLow