src: deduplicate X509Certificate::Fingerprint* #47978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All three functions do the same, except using different cryptographic hash functions. Move the common logic into a new template and use it directly.
tniessen
added
crypto
|
Review requested:
|
bnoordhuis
approved these changes
May 12, 2023
tniessen
added
author ready
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
panva
approved these changes
May 13, 2023
This comment was marked as outdated.
This comment was marked as outdated.
richardlau
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 93a1996 |
targos
pushed a commit
that referenced
this pull request
May 15, 2023
All three functions do the same, except using different cryptographic hash functions. Move the common logic into a new template and use it directly. PR-URL: #47978 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
All three functions do the same, except using different cryptographic hash functions. Move the common logic into a new template and use it directly. PR-URL: #47978 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
All three functions do the same, except using different cryptographic hash functions. Move the common logic into a new template and use it directly. PR-URL: nodejs#47978 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
X509Certificate::Fingerprint,X509Certificate::Fingerprint256, andX509Certificate::Fingerprint512all do the same, except using different cryptographic hash functions. Move the common logic into a template helper function.