Skip to content

buffer: use size_t instead of uint32_t to avoid segmentation fault #48033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 11, 2024
Merged

buffer: use size_t instead of uint32_t to avoid segmentation fault #48033

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ef83723
buffer: use size_t instead of uint32_t to avoid segmentation fault
Xstoudi May 16, 2023
855fd36
fix: fix another potential overflow
Xstoudi May 25, 2023
ca4471a
fix: remove blankline
Xstoudi May 25, 2023
98d8590
fix: format cpp
Xstoudi May 25, 2023
d80d6ca
Apply suggestions from code review
jasnell Dec 23, 2023
62f99dc
format_cpp
aduh95 May 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/string_bytes.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,11 +627,11 @@ size_t StringBytes::hex_encode(
char* dst,
size_t dlen) {
// We know how much we'll write, just make sure that there's space.
CHECK(dlen >= slen * 2 &&
"not enough space provided for hex encode");
CHECK(dlen >= MultiplyWithOverflowCheck<size_t>(slen, 2u) &&
"not enough space provided for hex encode");

dlen = slen * 2;
for (uint32_t i = 0, k = 0; k < dlen; i += 1, k += 2) {
for (size_t i = 0, k = 0; k < dlen; i += 1, k += 2) {
static const char hex[] = "0123456789abcdef";
uint8_t val = static_cast<uint8_t>(src[i]);
dst[k + 0] = hex[val >> 4];
Expand Down