Skip to content

Conversation

benjamingr
Copy link
Member

Support Symbol.dispose in mock timers. Letting users of TS/Babel (and everyone else as soon as v8 ships) use using with the mock timers.

cc @ErickWendel @nodejs/test_runner

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Jun 25, 2023
@benjamingr benjamingr force-pushed the add-dispose-mocktimers branch from ecb547c to 9ff2888 Compare June 25, 2023 18:12
@benjamingr benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 26, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 26, 2023
@nodejs-github-bot
Copy link
Collaborator

Copy link
Member

@ErickWendel ErickWendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjamingr benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 27, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 27, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@MoLow MoLow added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jun 29, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 29, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/48549
✔  Done loading data for nodejs/node/pull/48549
----------------------------------- PR info ------------------------------------
Title      test: add Symbol.dispose support to mocktimers (#48549)
Author     Benjamin Gruenbaum  (@benjamingr)
Branch     benjamingr:add-dispose-mocktimers -> nodejs:main
Labels     needs-ci, commit-queue-squash, test_runner
Commits    2
 - test: add Symbol.dispose support to mock timers
 - Update doc/api/test.md
Committers 2
 - Benjamin Gruenbaum 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/48549
Reviewed-By: Colin Ihrig 
Reviewed-By: Moshe Atlow 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Erick Wendel 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/48549
Reviewed-By: Colin Ihrig 
Reviewed-By: Moshe Atlow 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Erick Wendel 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - Update doc/api/test.md
   ℹ  This PR was created on Sun, 25 Jun 2023 18:10:38 GMT
   ✔  Approvals: 4
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/48549#pullrequestreview-1497181144
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/48549#pullrequestreview-1497192386
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/48549#pullrequestreview-1497609652
   ✔  - Erick Wendel (@erickwendel): https://github.com/nodejs/node/pull/48549#pullrequestreview-1498055208
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-06-29T06:44:07Z: https://ci.nodejs.org/job/node-test-pull-request/52554/
- Querying data for job/node-test-pull-request/52554/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/5409591686

@MoLow MoLow added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jun 29, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 29, 2023
@nodejs-github-bot nodejs-github-bot merged commit 1683e60 into nodejs:main Jun 29, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 1683e60

@benjamingr benjamingr deleted the add-dispose-mocktimers branch June 29, 2023 08:17
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
PR-URL: #48549
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Erick Wendel <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jul 3, 2023
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48549
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Erick Wendel <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48549
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Erick Wendel <[email protected]>
@ruyadorno
Copy link
Member

This is blocked from landing on v18.x-staging pending backport of #47775

targos pushed a commit that referenced this pull request Nov 27, 2023
PR-URL: #48549
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Erick Wendel <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
PR-URL: nodejs/node#48549
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Erick Wendel <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
PR-URL: nodejs/node#48549
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Erick Wendel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants