Skip to content

Conversation

mhdawson
Copy link
Member

  • refactor table so that it does not grow for every new version of Node.js
  • refer to latest version of table as the canonical reference
  • add info for Node-API v9

Refs: #48277

- refactor table so that it does not grow for
  every new version of Node.js
- refer to latest version of table as the canonical
  reference
- add info for Node-API v9

Refs: nodejs#48277

Signed-off-by: Michael Dawson <[email protected]>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/node-api

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. labels Jul 14, 2023
@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 18, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 18, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/48774
✔  Done loading data for nodejs/node/pull/48774
----------------------------------- PR info ------------------------------------
Title      doc: refactor node-api support matrix (#48774)
Author     Michael Dawson  (@mhdawson)
Branch     mhdawson:node-api-matrix -> nodejs:main
Labels     doc, node-api
Commits    2
 - doc: refactor node-api support matrix
 - Update doc/api/n-api.md
Committers 2
 - Michael Dawson 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/48774
Refs: https://github.com/nodejs/node/issues/48277
Reviewed-By: Richard Lau 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/48774
Refs: https://github.com/nodejs/node/issues/48277
Reviewed-By: Richard Lau 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 14 Jul 2023 18:27:39 GMT
   ✔  Approvals: 2
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/48774#pullrequestreview-1530886074
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48774#pullrequestreview-1531316690
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 48774
From https://github.com/nodejs/node
 * branch                  refs/pull/48774/merge -> FETCH_HEAD
✔  Fetched commits as 51513b23e88c..dcb5d42ab059
--------------------------------------------------------------------------------
[main 3bfbcfc40c] doc: refactor node-api support matrix
 Author: Michael Dawson 
 Date: Fri Jul 14 14:16:16 2023 -0400
 1 file changed, 25 insertions(+), 77 deletions(-)
[main bea5b1dbb1] Update doc/api/n-api.md
 Author: Michael Dawson 
 Date: Fri Jul 14 14:30:12 2023 -0400
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)

Executing: git node land --amend --yes
⚠ Found Refs: #48277, skipping..
--------------------------------- New Message ----------------------------------
doc: refactor node-api support matrix

  • refactor table so that it does not grow for
    every new version of Node.js
  • refer to latest version of table as the canonical
    reference
  • add info for Node-API v9

Refs: #48277

Signed-off-by: Michael Dawson [email protected]
PR-URL: #48774
Reviewed-By: Richard Lau [email protected]
Reviewed-By: Luigi Pinca [email protected]

[detached HEAD 64054c39a3] doc: refactor node-api support matrix
Author: Michael Dawson [email protected]
Date: Fri Jul 14 14:16:16 2023 -0400
1 file changed, 25 insertions(+), 77 deletions(-)
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update doc/api/n-api.md

PR-URL: #48774
Refs: #48277
Reviewed-By: Richard Lau [email protected]
Reviewed-By: Luigi Pinca [email protected]

[detached HEAD 81a72cfdc1] Update doc/api/n-api.md
Author: Michael Dawson [email protected]
Date: Fri Jul 14 14:30:12 2023 -0400
1 file changed, 1 insertion(+), 1 deletion(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/5591749050

@richardlau richardlau added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jul 18, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 19, 2023
@nodejs-github-bot nodejs-github-bot merged commit 38cc538 into nodejs:main Jul 19, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 38cc538

pluris pushed a commit to pluris/node that referenced this pull request Aug 6, 2023
- refactor table so that it does not grow for
  every new version of Node.js
- refer to latest version of table as the canonical
  reference
- add info for Node-API v9

Refs: nodejs#48277

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: nodejs#48774
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
pluris pushed a commit to pluris/node that referenced this pull request Aug 7, 2023
- refactor table so that it does not grow for
  every new version of Node.js
- refer to latest version of table as the canonical
  reference
- add info for Node-API v9

Refs: nodejs#48277

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: nodejs#48774
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
- refactor table so that it does not grow for
  every new version of Node.js
- refer to latest version of table as the canonical
  reference
- add info for Node-API v9

Refs: nodejs#48277

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: nodejs#48774
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
- refactor table so that it does not grow for
  every new version of Node.js
- refer to latest version of table as the canonical
  reference
- add info for Node-API v9

Refs: nodejs#48277

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: nodejs#48774
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
- refactor table so that it does not grow for
  every new version of Node.js
- refer to latest version of table as the canonical
  reference
- add info for Node-API v9

Refs: nodejs#48277

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: nodejs#48774
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
- refactor table so that it does not grow for
  every new version of Node.js
- refer to latest version of table as the canonical
  reference
- add info for Node-API v9

Refs: #48277

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #48774
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Aug 15, 2023
targos pushed a commit that referenced this pull request Nov 27, 2023
- refactor table so that it does not grow for
  every new version of Node.js
- refer to latest version of table as the canonical
  reference
- add info for Node-API v9

Refs: #48277

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #48774
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
- refactor table so that it does not grow for
  every new version of Node.js
- refer to latest version of table as the canonical
  reference
- add info for Node-API v9

Refs: nodejs/node#48277

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: nodejs/node#48774
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
- refactor table so that it does not grow for
  every new version of Node.js
- refer to latest version of table as the canonical
  reference
- add info for Node-API v9

Refs: nodejs/node#48277

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: nodejs/node#48774
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants