Skip to content

src,permission: restrict by default when pm enabled #48907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2023
Merged

src,permission: restrict by default when pm enabled #48907

merged 1 commit into from
Jul 26, 2023

Conversation

RafaelGSS
Copy link
Member

It goes according to the documentation:

When starting Node.js with --experimental-permission, the ability to access the file system through the fs module, spawn processes, use node:worker_threads and enable the runtime inspector will be restricted.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jul 24, 2023
@RafaelGSS RafaelGSS force-pushed the fix/restrict-by-default-pm-enabled branch from f1068f9 to cf6a089 Compare July 24, 2023 18:43
@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 24, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 24, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52922/

lpinca
lpinca reviewed Jul 24, 2023
View reviewed changes
@RafaelGSS RafaelGSS force-pushed the fix/restrict-by-default-pm-enabled branch from cf6a089 to 4ff3b90 Compare July 24, 2023 20:43
@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 24, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 24, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52923/

@github-actions github-actions bot mentioned this pull request Jul 25, 2023
Open
14 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52924/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52926/

@RafaelGSS RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 25, 2023
@github-actions github-actions bot mentioned this pull request Jul 26, 2023
Open
14 tasks
@RafaelGSS RafaelGSS added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 26, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 26, 2023
@nodejs-github-bot nodejs-github-bot merged commit 14e7bd8 into nodejs:main Jul 26, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 14e7bd8

@github-actions github-actions bot mentioned this pull request Jul 27, 2023
Open
18 tasks
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Jul 27, 2023
@RafaelGSS @Ceres6
src,permission: restrict by default when pm enabled
06fbbb8 
PR-URL: nodejs#48907
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@github-actions github-actions bot mentioned this pull request Jul 28, 2023
Open
19 tasks
rluvaton pushed a commit to rluvaton/node that referenced this pull request Jul 28, 2023
@RafaelGSS @rluvaton
src,permission: restrict by default when pm enabled
dbed52a 
PR-URL: nodejs#48907
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@github-actions github-actions bot mentioned this pull request Jul 31, 2023
Open
18 tasks
pluris pushed a commit to pluris/node that referenced this pull request Aug 6, 2023
@RafaelGSS
src,permission: restrict by default when pm enabled
e44db4d 
PR-URL: nodejs#48907
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
pluris pushed a commit to pluris/node that referenced this pull request Aug 7, 2023
@RafaelGSS
src,permission: restrict by default when pm enabled
b6a5f7b 
PR-URL: nodejs#48907
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@RafaelGSS @Ceres6
src,permission: restrict by default when pm enabled
d33d4a6 
PR-URL: nodejs#48907
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@RafaelGSS @Ceres6
src,permission: restrict by default when pm enabled
0ccb1d0 
PR-URL: nodejs#48907
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
@RafaelGSS @UlisesGascon
src,permission: restrict by default when pm enabled
6c05dd8 
PR-URL: nodejs#48907
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
RafaelGSS added a commit that referenced this pull request Aug 15, 2023
@RafaelGSS
src,permission: restrict by default when pm enabled
833e571 
PR-URL: #48907
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Aug 15, 2023
Merged
RafaelGSS added a commit that referenced this pull request Aug 17, 2023
@RafaelGSS
src,permission: restrict by default when pm enabled
62a46d9 
PR-URL: #48907
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@ShogunPanda ShogunPanda ShogunPanda approved these changes

@targos targos targos approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RafaelGSS @nodejs-github-bot @ShogunPanda @lpinca @targos @marco-ippolito