src: fix comment on StreamResource #49193
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
lpinca
approved these changes
Aug 18, 2023
github-actions
bot
removed
the
request-ci
github-actions
bot
removed
the
request-ci
This was referenced Aug 27, 2023
lpinca
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/49193 ✔ Done loading data for nodejs/node/pull/49193 ----------------------------------- PR info ------------------------------------ Title src: fix comment on StreamResource (#49193) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch ywave620:fix-comment -> nodejs:main Labels c++ Commits 1 - src: fix comment on StreamResource Committers 1 - rogertyang PR-URL: https://github.com/nodejs/node/pull/49193 Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49193 Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 16 Aug 2023 08:22:57 GMT ✔ Approvals: 1 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/49193#pullrequestreview-1585062540 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2023-08-26T11:02:31Z: https://ci.nodejs.org/job/node-test-pull-request/53564/ - Querying data for job/node-test-pull-request/53564/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6107731457 |
lpinca
pushed a commit
that referenced
this pull request
Sep 7, 2023
PR-URL: #49193 Reviewed-By: Luigi Pinca <[email protected]>
|
Landed in c86e700. |
ruyadorno
pushed a commit
that referenced
this pull request
Sep 28, 2023
PR-URL: #49193 Reviewed-By: Luigi Pinca <[email protected]>
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#49193 Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no function call EmitData in src directory. I deduce that the original author was talking
StreamResource::EmitRead()