Skip to content

doc: close a parenthesis #49525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2023
Merged

doc: close a parenthesis #49525

merged 1 commit into from
Sep 7, 2023

Conversation

regseb
Copy link
Contributor

@regseb regseb commented Sep 7, 2023

Close parenthesis in Package entry points chapter:

Existing packages introducing the "exports" field will prevent consumers of the package from using any entry points that are not defined, including the package.json (e.g. require('your-package/package.json'). This will likely be a breaking change.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 7, 2023
@lpinca lpinca added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Fast-track has been requested by @lpinca. Please 👍 to approve.

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 7, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 7, 2023
@nodejs-github-bot nodejs-github-bot merged commit e6fce82 into nodejs:main Sep 7, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in e6fce82

@regseb regseb deleted the patch-1 branch September 7, 2023 12:38
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@regseb @ruyadorno
doc: close a parenthesis
b4724e2 
PR-URL: #49525
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
This was referenced Sep 28, 2023
Closed
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@regseb @alexfernandez
doc: close a parenthesis
635459f 
PR-URL: nodejs#49525
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@regseb @nodejs-github-bot @lpinca @aduh95