Skip to content

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Oct 17, 2023

Ref: #49985

cc @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 17, 2023
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2023
@nodejs-github-bot
Copy link
Collaborator

@GeoffreyBooth
Copy link
Member

But #49997 is open to fix this.

@anonrig
Copy link
Member Author

anonrig commented Oct 17, 2023

But #49997 is open to fix this.

@MoLow responded and said that the pr didn't fix the issue. Ref: #49997 (comment)

@anonrig anonrig requested a review from jasnell October 18, 2023 01:03
@nodejs-github-bot
Copy link
Collaborator

@anonrig anonrig added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 18, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @anonrig. Please 👍 to approve.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina requested review from MoLow and cjihrig October 18, 2023 13:56
@anonrig anonrig added commit-queue Add this label to land a pull request using GitHub Actions. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Oct 18, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 18, 2023
@nodejs-github-bot nodejs-github-bot merged commit aa8282e into nodejs:main Oct 18, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in aa8282e

targos pushed a commit that referenced this pull request Oct 23, 2023
PR-URL: #50221
Refs: #49985
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
PR-URL: nodejs#50221
Refs: nodejs#49985
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2023
PR-URL: #50221
Refs: #49985
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
targos pushed a commit that referenced this pull request Nov 27, 2023
PR-URL: #50221
Refs: #49985
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
PR-URL: nodejs/node#50221
Refs: nodejs/node#49985
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
PR-URL: nodejs/node#50221
Refs: nodejs/node#49985
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants