Skip to content

tools: add staple to macOS notarized binaries #50625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2023
Merged

tools: add staple to macOS notarized binaries #50625

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc7bf89
tools: add macOS notarization stapler
UlisesGascon Nov 8, 2023
b46a70e
tools: remove return from macOS notarize script
UlisesGascon Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tools/osx-notarize.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,10 @@ xcrun notarytool submit \

if [ $? -eq 0 ]; then
echo "Notarization node-$pkgid.pkg submitted successfully."
exit 0
else
echo "Notarization node-$pkgid.pkg failed."
exit 1
fi

xcrun stapler staple "node-$pkgid.pkg"
echo "Stapler was successful."