Revert "tools: run build-windows workflow only on source changes"
#52320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4ab63db.
|
Review requested:
|
nodejs-github-bot
added
the
meta
richardlau
approved these changes
Apr 2, 2024
lpinca
approved these changes
Apr 2, 2024
lpinca
approved these changes
Apr 2, 2024
StefanStojanovic
approved these changes
Apr 2, 2024
UlisesGascon
approved these changes
Apr 2, 2024
marco-ippolito
approved these changes
Apr 3, 2024
marco-ippolito
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in d7aa8fc |
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
This reverts commit 4ab63db. PR-URL: #52320 Refs: #51596 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
This reverts commit 4ab63db. PR-URL: #52320 Refs: #51596 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 4ab63db.
Refs: #51596
build-windowsfrom running on build configuration changes (for example gyp file updates like build: speed up compilation of some V8 files #52083)