Skip to content

test benchmark change #52513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

test benchmark change #52513

wants to merge 1 commit into from

Conversation

rluvaton
Copy link
Member

@rluvaton rluvaton commented Apr 13, 2024 •
edited
Loading

This reverts commit 818c10e to check #52456 works

benchmark url

21:45:57 ++ Rscript benchmark/compare.R
21:45:58                                                                               confidence improvement accuracy (*)   (**)  (***)
21:45:58 abort_controller/abort-signal-static-abort.js kind='default-reason' n=5000000        ***    -43.28 %       ±0.55% ±0.74% ±0.98%
21:45:58 abort_controller/abort-signal-static-abort.js kind='same-reason' n=5000000           ***    -95.83 %       ±0.45% ±0.60% ±0.80%

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 13, 2024
@rluvaton rluvaton removed the needs-ci PRs that need a full CI run. label Apr 13, 2024
@rluvaton rluvaton closed this Apr 13, 2024
@rluvaton rluvaton deleted the test-benchmark branch April 13, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rluvaton @nodejs-github-bot