lib: fix TypeError with EventEmitter#on() abuse #527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| // https://github.com/iojs/io.js/issues/523 - second call should not throw. | ||
| var recv = {}; | ||
| EventEmitter.prototype.on.call(recv, 'event', function() {}); | ||
| EventEmitter.prototype.on.call(recv, 'event', function() {}); |
There was a problem hiding this comment.
Shouldn't this error happen on the first call also without the patch?
There was a problem hiding this comment.
No. The code path isn't reached the first time due to an optimization in how listeners are stored.
Commit 3e1b1dd missed a few files in test/parallel, this commit rectifies that. Only test/parallel/test-url.js still has a copyright header. I left it in because the original author is neither an io.js contributor nor a StrongLoop employee. PR-URL: nodejs#527 Reviewed-By: Colin Ihrig <[email protected]>
Add missing commas in parallel/test-event-emitter-get-max-listeners. Comma-less style is fine and dandy but it throws off vim's autoindent. PR-URL: nodejs#527 Reviewed-By: Colin Ihrig <[email protected]>
Commit 2931348 added EventEmitter#getMaxListeners() but introduced a regression when people abuse EventEmitter.prototype.on.call() to call EventEmitter#on() on a non-EE object. Add a workaround for that. Fixes: nodejs#523 PR-URL: nodejs#527 Reviewed-By: Colin Ihrig <[email protected]>
|
LGTM |
bnoordhuis
force-pushed
the
fix-issue-523
branch
from
141e603 to
ee9cd00
Compare
|
So nice. thank you. |
|
Thanks for the fix on behalf of sequelize :). And yes, we are clearly abusing EventEmitter by squashing bits and pieces of it onto promises until we can remove eventemitter support completely. Btw, we are working on getting rid of the offending bit of code, discussion here sequelize/sequelize#2882 |
This was referenced Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 2931348 added EventEmitter#getMaxListeners() but introduced a
regression when people abuse EventEmitter.prototype.on.call() to call
EventEmitter#on() on a non-EE object. Add a workaround for that.
Fixes: iojs#523
R=@yosuke-furukawa