-
-
Notifications
You must be signed in to change notification settings - Fork 33.5k
process: add process.getBuiltinModule(id) #52762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
aa54e26
doc: improve explanation about built-in modules
joyeecheung e83917e
process: add process.getBuiltinModule(id)
joyeecheung 06f8432
fixup! process: add process.getBuiltinModule(id)
joyeecheung 4051f58
fixup! fixup! process: add process.getBuiltinModule(id)
joyeecheung 87251ab
fixup! process: add process.getBuiltinModule(id)
joyeecheung 0f20ee2
fixup! fixup! process: add process.getBuiltinModule(id)
joyeecheung c07e5e4
fixup! fixup! fixup! process: add process.getBuiltinModule(id)
joyeecheung File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
import { isMainThread } from '../common/index.mjs'; | ||
import assert from 'node:assert'; | ||
import { builtinModules } from 'node:module'; | ||
|
||
for (const invalid of [1, undefined, null, false, [], {}, () => {}, Symbol('test')]) { | ||
assert.throws(() => process.getBuiltinModule(invalid), { code: 'ERR_INVALID_ARG_TYPE' }); | ||
} | ||
|
||
for (const invalid of [ | ||
'invalid', 'test', 'sea', 'test/reporter', 'internal/bootstrap/realm', | ||
'internal/deps/undici/undici', 'internal/util', | ||
]) { | ||
assert.strictEqual(process.getBuiltinModule(invalid), undefined); | ||
} | ||
|
||
// Check that createRequire()(id) returns the same thing as process.getBuiltinModule(id). | ||
const require = process.getBuiltinModule('module').createRequire(import.meta.url); | ||
const publicBuiltins = new Set(builtinModules); | ||
|
||
// Remove built-ins not available in the current setup. | ||
if (!isMainThread) { | ||
publicBuiltins.delete('trace_events'); | ||
} | ||
|
||
for (const id of publicBuiltins) { | ||
assert.strictEqual(process.getBuiltinModule(id), require(id)); | ||
} | ||
// Check that import(id).default returns the same thing as process.getBuiltinModule(id). | ||
for (const id of publicBuiltins) { | ||
const imported = await import(`node:${id}`); | ||
assert.strictEqual(process.getBuiltinModule(id), imported.default); | ||
} | ||
|
||
// publicBuiltins does not include 'test' which requires the node: prefix. | ||
const ids = publicBuiltins.add('test'); | ||
// Check that import(id).default returns the same thing as process.getBuiltinModule(id). | ||
for (const id of ids) { | ||
const prefixed = `node:${id}`; | ||
const imported = await import(prefixed); | ||
assert.strictEqual(process.getBuiltinModule(prefixed), imported.default); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.