[v20.x backport] test_runner: make end of work check stricter #53123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
marco-ippolito
approved these changes
May 23, 2024
github-actions
bot
removed
the
request-ci
marco-ippolito
force-pushed
the
v20.x-staging
branch
from
07c45ba to
e6d9fbe
Compare
marco-ippolito
force-pushed
the
backport-52326-to-20
branch
from
e056a7c to
046d993
Compare
marco-ippolito
added
the
request-ci
github-actions
bot
removed
the
request-ci
marco-ippolito
force-pushed
the
v20.x-staging
branch
3 times, most recently
from
a924e20 to
473fa73
Compare
marco-ippolito
added
the
request-ci
github-actions
bot
removed
the
request-ci
marco-ippolito
added
the
request-ci
github-actions
bot
removed
the
request-ci
This commit updates the logic that checks for the end of the test run. Prior to this change, it was possible for root.run() to be called multiple times because of the way pending subtests were tracked. The extra calls to root.run() were harmless, but could trigger an EventEmitter leak warning due to 'abort' listeners being created. PR-URL: nodejs#52326 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
marco-ippolito
force-pushed
the
backport-52326-to-20
branch
from
046d993 to
4481c1b
Compare
marco-ippolito
added
the
request-ci
github-actions
bot
removed
the
request-ci
marco-ippolito
force-pushed
the
v20.x-staging
branch
from
91dea21 to
44268c2
Compare
targos
force-pushed
the
v20.x-staging
branch
2 times, most recently
from
47be236 to
9e1c229
Compare
|
This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open. |
|
Closing this because it has stalled. Feel free to reopen if this issue/PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the logic that checks for the end of the test run. Prior to this change, it was possible for root.run() to be called multiple times because of the way pending subtests were tracked. The extra calls to root.run() were harmless, but could trigger an EventEmitter leak warning due to 'abort' listeners being created.
PR-URL: #52326
Reviewed-By: Benjamin Gruenbaum [email protected]
Reviewed-By: Moshe Atlow [email protected]
Reviewed-By: Chemi Atlow [email protected]