docs: remove incorrect entry from changelog #546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Proudly made with the github™ editor |
|
You should remove the R=@bnoordhuis from the commit log and maybe mention the revert commit. |
|
Dang! now I still don't get to use the merge button. |
`url.format()` doesn't take a `path` option; the change that introduced it was reverted in 913addb. PR: #546 Reviewed-by: Ben Noordhuis <[email protected]>
piscisaureus
force-pushed
the
piscisaureus-patch-1
branch
from
5ebdc6f to
60402b9
Compare
This was referenced Sep 13, 2021
This was referenced Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R=@bnoordhuis