[v22.x backport] lib: ensure FORCE_COLOR forces color output in non-TTY environments #56631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
pmarchini
force-pushed
the
backport/v22.x-force-color
branch
from
7ec5bd7 to
61c0540
Compare
pmarchini
changed the title
github-actions
bot
removed
the
request-ci
BridgeAR
approved these changes
Jan 17, 2025
lpinca
approved these changes
Jan 17, 2025
richardlau
changed the title
aduh95
changed the title
PR-URL: nodejs#55404 Backport-PR-URL: nodejs#56631 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]>
aduh95
force-pushed
the
backport/v22.x-force-color
branch
from
61c0540 to
f0c556f
Compare
|
Landed in 793981a |
aduh95
pushed a commit
that referenced
this pull request
Feb 4, 2025
PR-URL: #55404 Backport-PR-URL: #56631 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Feb 6, 2025
PR-URL: #55404 Backport-PR-URL: #56631 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should backport #55404, as a manual backport is required, and also addresses #52249 in this version