Skip to content

Conversation

richardlau
Copy link
Member

This reverts commit 581b444.

Refs: #56063


Fixes failing Test Linux workflow.

../src/cleanup_queue.cc:18:32: error: 'greater' may not intend to support class template argument deduction [-Werror,-Wctad-maybe-unsupported]
   18 |   std::ranges::sort(callbacks, std::greater());
      |                                ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/stl_function.h:390:12: note: add a deduction guide to suppress this warning
  390 |     struct greater : public binary_function<_Tp, _Tp, bool>
      |            ^
1 error generated.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jan 31, 2025
@richardlau richardlau added request-ci Add this label to start a Jenkins CI on a PR. fast-track PRs that do not need to wait for 48 hours to land. labels Jan 31, 2025
Copy link
Contributor

Fast-track has been requested by @richardlau. Please 👍 to approve.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 31, 2025
@nodejs-github-bot

This comment was marked as outdated.

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.20%. Comparing base (6857dbc) to head (fb46c4e).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
src/cleanup_queue.cc 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #56846      +/-   ##
==========================================
+ Coverage   88.70%   89.20%   +0.50%     
==========================================
  Files         663      663              
  Lines      192012   192012              
  Branches    36613    36933     +320     
==========================================
+ Hits       170317   171287     +970     
+ Misses      14520    13609     -911     
+ Partials     7175     7116      -59     
Files with missing lines Coverage Δ
src/cleanup_queue-inl.h 92.30% <ø> (ø)
src/cleanup_queue.h 100.00% <ø> (ø)
src/cleanup_queue.cc 85.71% <88.88%> (ø)

... and 93 files with indirect coverage changes

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 1, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 1, 2025
@nodejs-github-bot nodejs-github-bot merged commit ad84558 into nodejs:main Feb 1, 2025
72 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in ad84558

@aduh95 aduh95 added dont-land-on-v18.x dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Feb 1, 2025
@richardlau richardlau deleted the revert-56063 branch February 4, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants