Skip to content

test: update webstorage wpt #56963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/fixtures/wpt/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ Last update:
- WebCryptoAPI: https://github.com/web-platform-tests/wpt/tree/3e3374efde/WebCryptoAPI
- webidl/ecmascript-binding/es-exceptions: https://github.com/web-platform-tests/wpt/tree/a370aad338/webidl/ecmascript-binding/es-exceptions
- webmessaging/broadcastchannel: https://github.com/web-platform-tests/wpt/tree/6495c91853/webmessaging/broadcastchannel
- webstorage: https://github.com/web-platform-tests/wpt/tree/9dafa89214/webstorage
- webstorage: https://github.com/web-platform-tests/wpt/tree/1291340aaa/webstorage

[Web Platform Tests]: https://github.com/web-platform-tests/wpt
[`git node wpt`]: https://github.com/nodejs/node-core-utils/blob/main/docs/git-node.md#git-node-wpt
2 changes: 1 addition & 1 deletion test/fixtures/wpt/versions.json
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@
"path": "webmessaging/broadcastchannel"
},
"webstorage": {
"commit": "9dafa892146c4b5b1f604a39b3cf8677f8f70d44",
"commit": "1291340aaaa6e73db43b412e47401eca3830c556",
"path": "webstorage"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
for (let id in ids) {
assert_true(id !== undefined, "id is not undefined");
}
// Note: we use assert_true, rather than assert_equals because we're
// Note: we use assert_true, rather than assert_equals becuase we're
// setting random numbers as IDs - this would mean expectations
// files wouldn't work as intended.
assert_true(crossSiteIframeAboutBlankID !== crossSiteIframeID,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
assert_true(typeof sameSiteID === "string");

if (location.origin !== altOrigin) {
crossSiteWindow = window.open(`${altOrigin}/webstorage/localstorage-basic-partitioned.tentative.sub.html`, "", "noopener=false");
crossSiteWindow = window.open(`${altOrigin}/webstorage/localstorage-basic-partitioned.sub.html`, "", "noopener=false");
t.add_cleanup(() => crossSiteWindow.close());
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
// new cross-site window that contains our shared-iframe to repeat
// the process in a cross-site environment.
if (location.origin !== altOrigin) {
crossSiteWindow = window.open(`${altOrigin}/webstorage/sessionStorage-basic-partitioned.tentative.sub.html`, "", "noopener=false");
crossSiteWindow = window.open(`${altOrigin}/webstorage/sessionStorage-basic-partitioned.sub.html`, "", "noopener=false");
t.add_cleanup(() => crossSiteWindow.close());
}
}
Expand Down
3 changes: 3 additions & 0 deletions test/wpt/status/webstorage.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
"localstorage-cross-origin-iframe.tentative.https.window.js": {
"skip": "iframes are not supported in Node.js."
},
"localstorage-cross-origin-iframe.https.window.js": {
"skip": "iframes are not supported in Node.js."
},
"storage_local_window_open.window.js": {
"skip": "window.open() is not supported in Node.js."
},
Expand Down
Loading