test: add case for unrecognised fields within pjson "exports" #57026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57026 +/- ##
=======================================
Coverage 89.11% 89.11%
=======================================
Files 665 665
Lines 193193 193203 +10
Branches 37212 37217 +5
=======================================
+ Hits 172158 172169 +11
+ Misses 13775 13771 -4
- Partials 7260 7263 +3 |
JakobJingleheimer
added
module
|
Fast-track has been requested by @JakobJingleheimer. Please 👍 to approve. |
aduh95
approved these changes
Feb 13, 2025
JakobJingleheimer
force-pushed
the
module/add-case-for-types-within-exports
branch
from
beb548e to
6320ada
Compare
JakobJingleheimer
changed the title
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
JakobJingleheimer
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/57026 ✔ Done loading data for nodejs/node/pull/57026 ----------------------------------- PR info ------------------------------------ Title test: add case for unrecognised fields within pjson "exports" (#57026) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch JakobJingleheimer:module/add-case-for-types-within-exports -> nodejs:main Labels module, test, fast-track, author ready, loaders, commit-queue-squash Commits 1 - test: add case for unrecognised fields within pjson "exports" Committers 1 - Jacob Smith <[email protected]> PR-URL: https://github.com/nodejs/node/pull/57026 Reviewed-By: Antoine du Hamel <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/57026 Reviewed-By: Antoine du Hamel <[email protected]> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - test: add case for unrecognised fields within pjson "exports" ℹ This PR was created on Thu, 13 Feb 2025 11:41:08 GMT ✔ Approvals: 1 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/57026#pullrequestreview-2615428445 ℹ This PR is being fast-tracked ✘ This PR needs to wait 143 more hours to land (or 23 hours if there is one more approval) (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-02-14T08:35:43Z: https://ci.nodejs.org/job/node-test-pull-request/65197/ - Querying data for job/node-test-pull-request/65197/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/13328873697 |
aduh95
removed
fast-track
JakobJingleheimer
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
nodejs-github-bot
added
the
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/57026 ✔ Done loading data for nodejs/node/pull/57026 ----------------------------------- PR info ------------------------------------ Title test: add case for unrecognised fields within pjson "exports" (#57026) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch JakobJingleheimer:module/add-case-for-types-within-exports -> nodejs:main Labels module, test, author ready, loaders, commit-queue-squash Commits 1 - test: add case for unrecognised fields within pjson "exports" Committers 1 - Jacob Smith <[email protected]> PR-URL: https://github.com/nodejs/node/pull/57026 Reviewed-By: Antoine du Hamel <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/57026 Reviewed-By: Antoine du Hamel <[email protected]> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - test: add case for unrecognised fields within pjson "exports" ℹ This PR was created on Thu, 13 Feb 2025 11:41:08 GMT ✔ Approvals: 1 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/57026#pullrequestreview-2615428445 ✘ This PR needs to wait 115 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-02-14T12:10:34Z: https://ci.nodejs.org/job/node-test-pull-request/65197/ - Querying data for job/node-test-pull-request/65197/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/13346621315 |
|
What happened to commit-queue waiting and then running once enough time has passed? |
jasnell
approved these changes
Feb 15, 2025
JakobJingleheimer
added
the
commit-queue
jasnell
pushed a commit
that referenced
this pull request
Feb 15, 2025
PR-URL: #57026 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 61a57f7 |
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/57026 ✔ Done loading data for nodejs/node/pull/57026 ----------------------------------- PR info ------------------------------------ Title test: add case for unrecognised fields within pjson "exports" (#57026) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch JakobJingleheimer:module/add-case-for-types-within-exports -> nodejs:main Labels module, test, author ready, commit-queue-failed, loaders, commit-queue-squash Commits 1 - test: add case for unrecognised fields within pjson "exports" Committers 1 - Jacob Smith <[email protected]> PR-URL: https://github.com/nodejs/node/pull/57026 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/57026 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 13 Feb 2025 11:41:08 GMT ✔ Approvals: 2 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/57026#pullrequestreview-2615428445 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/57026#pullrequestreview-2619484879 ⚠ This PR was closed on Sat, 15 Feb 2025 19:45:30 GMT ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-02-15T16:09:38Z: https://ci.nodejs.org/job/node-test-pull-request/65197/ - Querying data for job/node-test-pull-request/65197/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/13348107298 |
targos
pushed a commit
that referenced
this pull request
Feb 17, 2025
PR-URL: #57026 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
acidiney
pushed a commit
to acidiney/node
that referenced
this pull request
Feb 23, 2025
PR-URL: nodejs#57026 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Apr 2, 2025
PR-URL: #57026 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Apr 3, 2025
PR-URL: #57026 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 16, 2025
PR-URL: #57026 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 17, 2025
PR-URL: #57026 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.