-
-
Notifications
You must be signed in to change notification settings - Fork 33k
doc: add "Do I still need this dependency for my Node.js app?" to ambassadors program #57600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
20c83cf
doc: fix heading levels in advocacy-ambassador-program.md
bmuenzenmeyer a632929
doc: fix typos
bmuenzenmeyer 88373f1
doc: add dependency discussion to ambassadors program
bmuenzenmeyer 12abe2f
doc: format doc\contributing\advocacy-ambassador-program.md
bmuenzenmeyer 0c54864
doc: format doc\contributing\advocacy-ambassador-program.md
bmuenzenmeyer 6dd5483
Update doc/contributing/advocacy-ambassador-program.md
bmuenzenmeyer 2d049d4
doc: add node --run suggestion
bmuenzenmeyer 715b326
doc: manually format file again
bmuenzenmeyer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Npm run vs. Node --run can be added as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree that this is a useful addition, and did discuss it within https://noti.st/brianmuenzenmeyer/5ep4ZM/do-i-still-need-this-dependency-for-my-node-js-app - though I question whether most would describe their package manager as a dependency. Not trying to be pedantic.
The angle I took in the talk was that
node --run
does make documentation a bit more flexible, so that's an obvious plus.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added via 2d049d4