Skip to content

lib: use SafeMap primordial for ActiveAsyncContextFrame #57670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2025
Merged

lib: use SafeMap primordial for ActiveAsyncContextFrame #57670

merged 1 commit into from
Apr 8, 2025

Conversation

gurgunday
Copy link
Member

Not sure if this was intentional, but (In)ActiveAsyncContextFrame seems to extend Map without using primordials

Tracked down the change to ef6b9ff

Cc @bengl

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 29, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 29, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.23%. Comparing base (af75d04) to head (d2b3308).
Report is 85 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #57670   +/-   ##
=======================================
  Coverage   90.23%   90.23%           
=======================================
  Files         630      630           
  Lines      185055   185056    +1     
  Branches    36221    36220    -1     
=======================================
+ Hits       166984   166989    +5     
  Misses      11043    11043           
+ Partials     7028     7024    -4
Files with missing lines Coverage Δ
lib/internal/async_context_frame.js 76.62% <100.00%> (+0.30%) ⬆️

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Flarna Flarna added the async_local_storage AsyncLocalStorage label Apr 4, 2025
@Flarna Flarna added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 4, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 4, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@gurgunday gurgunday added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 4, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66117/

@Flarna Flarna added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 8, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 8, 2025
@nodejs-github-bot nodejs-github-bot merged commit 1e95107 into nodejs:main Apr 8, 2025
72 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 1e95107

JonasBa pushed a commit to JonasBa/node that referenced this pull request Apr 11, 2025
@gurgunday @JonasBa
lib: use Map primordial for ActiveAsyncContextFrame
8e79458 
PR-URL: nodejs#57670
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@gurgunday @RafaelGSS
lib: use Map primordial for ActiveAsyncContextFrame
ab56bf9 
PR-URL: #57670
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@gurgunday @RafaelGSS
lib: use Map primordial for ActiveAsyncContextFrame
68c5954 
PR-URL: #57670
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@gurgunday @aduh95
lib: use Map primordial for ActiveAsyncContextFrame
772bc9e 
PR-URL: #57670
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@gurgunday @RafaelGSS
lib: use Map primordial for ActiveAsyncContextFrame
27723bd 
PR-URL: #57670
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@gurgunday @aduh95
lib: use Map primordial for ActiveAsyncContextFrame
4bcf536 
PR-URL: #57670
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@gurgunday @aduh95
lib: use Map primordial for ActiveAsyncContextFrame
08a2330 
PR-URL: #57670
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@gurgunday @aduh95
lib: use Map primordial for ActiveAsyncContextFrame
750fdc6 
PR-URL: #57670
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@gurgunday @aduh95
lib: use Map primordial for ActiveAsyncContextFrame
fe539f7 
PR-URL: #57670
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
@github-actions github-actions bot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
@gurgunday @aduh95
lib: use Map primordial for ActiveAsyncContextFrame
f7e2902 
PR-URL: #57670
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
@ghost ghost mentioned this pull request Jun 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@jasnell jasnell jasnell approved these changes

@targos targos targos approved these changes

@Flarna Flarna Flarna approved these changes

Assignees
No one assigned
Labels
async_local_storage AsyncLocalStorage author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gurgunday @nodejs-github-bot @ljharb @jasnell @targos @Flarna