Skip to content

tools: enable linter in test/fixtures/test-runner/output #57698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 4, 2025
Merged

tools: enable linter in test/fixtures/test-runner/output #57698

merged 4 commits into from
Apr 4, 2025

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 1, 2025

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Apr 1, 2025
@codecov Codecov
Copy link

codecov bot commented Apr 1, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.25%. Comparing base (633ba00) to head (b1e81eb).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #57698      +/-   ##
==========================================
+ Coverage   90.24%   90.25%   +0.01%     
==========================================
  Files         630      630              
  Lines      184990   184990              
  Branches    36214    36216       +2     
==========================================
+ Hits       166948   166968      +20     
- Misses      11001    11002       +1     
+ Partials     7041     7020      -21

see 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 merged commit ad07869 into nodejs:main Apr 4, 2025
19 checks passed
@aduh95
Copy link
Contributor Author

aduh95 commented Apr 4, 2025

Landed in ad07869

@aduh95 aduh95 deleted the lint-test-runner-output branch April 4, 2025 08:44
JonasBa pushed a commit to JonasBa/node that referenced this pull request Apr 11, 2025
@aduh95 @JonasBa
tools: enable linter in test/fixtures/test-runner/output
1418789 
PR-URL: nodejs#57698
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@aduh95 @RafaelGSS
tools: enable linter in test/fixtures/test-runner/output
392fe2f 
PR-URL: #57698
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@aduh95 @RafaelGSS
tools: enable linter in test/fixtures/test-runner/output
bbbf498 
PR-URL: #57698
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
aduh95 added a commit that referenced this pull request May 6, 2025
@aduh95
tools: enable linter in test/fixtures/test-runner/output
91cc37a 
PR-URL: #57698
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@aduh95 @RafaelGSS
tools: enable linter in test/fixtures/test-runner/output
c8b1d57 
PR-URL: #57698
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
aduh95 added a commit that referenced this pull request May 17, 2025
@aduh95
tools: enable linter in test/fixtures/test-runner/output
dc732b1 
PR-URL: #57698
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
aduh95 added a commit that referenced this pull request May 17, 2025
@aduh95
tools: enable linter in test/fixtures/test-runner/output
e9c1157 
PR-URL: #57698
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
@github-actions github-actions bot mentioned this pull request May 19, 2025
Merged
aduh95 added a commit that referenced this pull request May 19, 2025
@aduh95
tools: enable linter in test/fixtures/test-runner/output
ef5275b 
PR-URL: #57698
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
codebytere added a commit to electron/electron that referenced this pull request May 23, 2025
@codebytere
tools: enable linter in test/fixtures/test\-runner/output
e59ebff 
nodejs/node#57698
codebytere added a commit to electron/electron that referenced this pull request May 26, 2025
@codebytere
tools: enable linter in test/fixtures/test\-runner/output
8aea6c6 
nodejs/node#57698
codebytere added a commit to electron/electron that referenced this pull request May 29, 2025
@codebytere
tools: enable linter in test/fixtures/test\-runner/output
f20b264 
nodejs/node#57698
codebytere added a commit to electron/electron that referenced this pull request Jun 2, 2025
@codebytere
tools: enable linter in test/fixtures/test\-runner/output
a534bde 
nodejs/node#57698
jkleinsc pushed a commit to electron/electron that referenced this pull request Jun 2, 2025
@electron-roller @codebytere
chore: bump node to v22.16.0 (main) (#47217)
82a59d9 
* chore: bump node in DEPS to v22.16.0

* crypto: remove BoringSSL dh-primes addition

nodejs/node#57023

* tools: enable linter in test/fixtures/test\-runner/output

nodejs/node#57698

* src: improve thread safety of TaskQueue

nodejs/node#57910

* buffer: define global v8::CFunction objects as const

nodejs/node#57676

* src: disable abseil deadlock detection

nodejs/node#57582

* zlib: fix pointer alignment

nodejs/node#57727

* chore: fixup patch indices

* src: set default config as node.config.json

nodejs/node#57171

* src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>

nodejs/node#57578

* test: disable chmod tests failing in Docker

nodejs/node#58326

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>
codebytere added a commit to electron/electron that referenced this pull request Jun 3, 2025
@codebytere
tools: enable linter in test/fixtures/test\-runner/output
b55bf4f 
nodejs/node#57698
codebytere added a commit to electron/electron that referenced this pull request Jun 3, 2025
@codebytere
tools: enable linter in test/fixtures/test\-runner/output
a815028 
nodejs/node#57698
codebytere added a commit to electron/electron that referenced this pull request Jun 3, 2025
@codebytere
tools: enable linter in test/fixtures/test\-runner/output
fa0cd0c 
nodejs/node#57698
codebytere added a commit to electron/electron that referenced this pull request Jun 3, 2025
@codebytere
tools: enable linter in test/fixtures/test\-runner/output
1756314 
nodejs/node#57698
codebytere added a commit to electron/electron that referenced this pull request Jun 3, 2025
@codebytere
tools: enable linter in test/fixtures/test\-runner/output
690dde2 
nodejs/node#57698
codebytere added a commit to electron/electron that referenced this pull request Jun 3, 2025
@codebytere
tools: enable linter in test/fixtures/test\-runner/output
7883d8d 
nodejs/node#57698
codebytere added a commit to electron/electron that referenced this pull request Jun 4, 2025
@electron-roller @codebytere
chore: bump node to v22.16.0 (36-x-y) (#47214)
63c7215 
* chore: bump node in DEPS to v22.16.0

* crypto: remove BoringSSL dh-primes addition

nodejs/node#57023

* tools: enable linter in test/fixtures/test\-runner/output

nodejs/node#57698

* src: improve thread safety of TaskQueue

nodejs/node#57910

* buffer: define global v8::CFunction objects as const

nodejs/node#57676

* src: disable abseil deadlock detection

nodejs/node#57582

* zlib: fix pointer alignment

nodejs/node#57727

* chore: fixup patch indices

* src: set default config as node.config.json

nodejs/node#57171

* src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>

nodejs/node#57578

* test: disable chmod tests failing in Docker

nodejs/node#58326

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@MoLow MoLow MoLow approved these changes

@pmarchini pmarchini pmarchini approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aduh95 @jasnell @MoLow @pmarchini @nodejs-github-bot