repl: fix multiline history editing string order #57874

puskin · 2025-04-14T14:58:50Z

fixing an issue introduced in the last commit of #57400:
when editing a multiline history in REPL, the string gets reversed.

Added relevant automated tests

lib/internal/readline/interface.js

BridgeAR

Would this also fix the flaky behavior reported in the comment? :)

#57400 (comment)

codecov · 2025-04-14T15:47:49Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.24%. Comparing base (f89baf2) to head (03cd310).
Report is 297 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #57874      +/-   ##
==========================================
- Coverage   90.24%   90.24%   -0.01%     
==========================================
  Files         630      630              
  Lines      185670   185694      +24     
  Branches    36401    36404       +3     
==========================================
+ Hits       167567   167577      +10     
- Misses      10992    10999       +7     
- Partials     7111     7118       +7

Files with missing lines	Coverage Δ
lib/internal/readline/interface.js	`96.79% <100.00%> (+0.01%)`	⬆️

... and 37 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

puskin · 2025-04-14T16:06:14Z

Would this also fix the flaky behavior reported in the comment? :)

#57400 (comment)

I just added some code which could fix the flakiness... I am not sure if it is good / clean enough tho, I didn't have any cooler idea 😞

BridgeAR

I don't think the wait should make a difference for the test being flaky. I could imagine we run tests in parallel that use the same repl file to write to and they conflict with each other. Or is that unique to the current tmp directory?

The flaky result said we had two history entries.

puskin · 2025-04-14T17:28:30Z

Yeah I interpreted the two history entries as in a weird combination of keypresses which were not properly "awaited" for. Unfortunately I cannot reproduce the issue, let me investigate the "multiple access to the same history file" path

EDIT: applied your suggestion, let's see if it happens again!

nodejs-github-bot · 2025-04-14T23:34:26Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66271/

nodejs-github-bot · 2025-04-15T07:36:46Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66276/

test/parallel/test-repl-multiline-navigation.js

nodejs-github-bot · 2025-04-15T10:10:03Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66279/

nodejs-github-bot · 2025-04-15T13:47:37Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66282/

nodejs-github-bot · 2025-04-15T15:59:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66286/

nodejs-github-bot · 2025-04-16T05:54:33Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66294/

nodejs-github-bot · 2025-04-16T15:01:41Z

Landed in af85f3f

PR-URL: #57874 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

aduh95 · 2025-05-18T17:39:50Z

test-repl-multiline-navigation is failing on Windows with this change and on v22.x-staging, it would require a manual backport if we want it on 22.x

nodejs-github-bot added needs-ci PRs that need a full CI run. readline Issues and PRs related to the built-in readline module. labels Apr 14, 2025

BridgeAR reviewed Apr 14, 2025

View reviewed changes

lib/internal/readline/interface.js Show resolved Hide resolved

BridgeAR reviewed Apr 14, 2025

View reviewed changes

puskin force-pushed the repl-edit-multiline-reverse-strig branch from 50800d0 to 39b827c Compare April 14, 2025 16:05

BridgeAR reviewed Apr 14, 2025

View reviewed changes

puskin force-pushed the repl-edit-multiline-reverse-strig branch from 39b827c to 4a9c482 Compare April 14, 2025 17:35

BridgeAR approved these changes Apr 14, 2025

View reviewed changes

BridgeAR added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 14, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 14, 2025

puskin mentioned this pull request Apr 15, 2025

repl: add support for multiline history #57400

Merged

lpinca reviewed Apr 15, 2025

View reviewed changes

test/parallel/test-repl-multiline-navigation.js Outdated Show resolved Hide resolved

test/parallel/test-repl-multiline-navigation.js Outdated Show resolved Hide resolved

puskin force-pushed the repl-edit-multiline-reverse-strig branch from 4a9c482 to 84f0885 Compare April 15, 2025 08:57

repl: fix multiline history editing string order

03cd310

puskin force-pushed the repl-edit-multiline-reverse-strig branch from 84f0885 to 03cd310 Compare April 15, 2025 09:02

lpinca approved these changes Apr 15, 2025

View reviewed changes

BridgeAR added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 15, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 15, 2025

pmarchini added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 16, 2025

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 16, 2025

nodejs-github-bot merged commit af85f3f into nodejs:main Apr 16, 2025
63 checks passed

RafaelGSS pushed a commit that referenced this pull request May 1, 2025

repl: fix multiline history editing string order

b1df3e9

PR-URL: #57874 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

RafaelGSS mentioned this pull request May 1, 2025

2025-05-06, Version 24.0.0 (Current) #57609

Merged

RafaelGSS pushed a commit that referenced this pull request May 2, 2025

repl: fix multiline history editing string order

ab99ee6

PR-URL: #57874 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

aduh95 pushed a commit that referenced this pull request May 6, 2025

repl: fix multiline history editing string order

fc75cba

PR-URL: #57874 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

aduh95 pushed a commit that referenced this pull request May 6, 2025

repl: fix multiline history editing string order

a85647a

PR-URL: #57874 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

RafaelGSS pushed a commit that referenced this pull request May 14, 2025

repl: fix multiline history editing string order

cfe5036

PR-URL: #57874 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

aduh95 pushed a commit that referenced this pull request May 16, 2025

repl: fix multiline history editing string order

037b2d8

PR-URL: #57874 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

aduh95 pushed a commit that referenced this pull request May 17, 2025

repl: fix multiline history editing string order

4b8cce6

PR-URL: #57874 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

aduh95 pushed a commit that referenced this pull request May 17, 2025

repl: fix multiline history editing string order

f06d28c

PR-URL: #57874 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

aduh95 pushed a commit that referenced this pull request May 17, 2025

repl: fix multiline history editing string order

de954dc

PR-URL: #57874 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

aduh95 added the backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. label May 18, 2025

Uh oh!

repl: fix multiline history editing string order #57874

repl: fix multiline history editing string order #57874

Uh oh!

Conversation

puskin commented Apr 14, 2025

Uh oh!

Uh oh!

BridgeAR left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Apr 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

puskin commented Apr 14, 2025

Uh oh!

BridgeAR left a comment

Choose a reason for hiding this comment

Uh oh!

puskin commented Apr 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 14, 2025

Uh oh!

nodejs-github-bot commented Apr 15, 2025

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 15, 2025

Uh oh!

nodejs-github-bot commented Apr 15, 2025

Uh oh!

nodejs-github-bot commented Apr 15, 2025

Uh oh!

nodejs-github-bot commented Apr 16, 2025

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 16, 2025

Uh oh!

aduh95 commented May 18, 2025

Uh oh!

Uh oh!

codecov bot commented Apr 14, 2025 •

edited

Loading

puskin commented Apr 14, 2025 •

edited

Loading