util(styleText): optimise + benchmark

[AugustinMauroy]

I had modify logic behind. using a reducer, it's should be quicker. And I had updated benchmark

Plus I had updated test to use node:test in goal of having better DX when something fails.

[nodejs-github-bot]

Review requested:

• @nodejs/performance

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.21%. Comparing base (6cd1c09) to head (a9d13f2).
Report is 16 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #58063   +/-   ##
=======================================
  Coverage   90.21%   90.21%           
=======================================
  Files         630      630           
  Lines      186391   186448   +57     
  Branches    36610    36620   +10     
=======================================
+ Hits       168146   168209   +63     
+ Misses      11066    11038   -28     
- Partials     7179     7201   +22     

Files with missing lines	Coverage Δ
lib/util.js	97.77% <100.00%> (+0.01%)	⬆️

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[lpinca]

Plus I had updated test to use node:test in goal of having better DX when something fails.

Please don't do that, we discussed it a lot. Those refactors are not useful.

[AugustinMauroy]

Please don't do that, we discussed it a lot. Those refactors are not useful.

oh okay, surprising because the use cases with the it allow you to find your way around the test and, in the event of a failure, search the codebase.
Do you have a link to the discussion?

[lpinca]

Start here #54796 and here #56027, follow the links there.

[marco-ippolito]

early return will skip validation so its a necessary overhead
#56722 (comment)

[RafaelGSS]

As Marco mentioned, the "overhead" is necessary.

[AugustinMauroy]

Can I just keep benchmark change ?

[RafaelGSS]

Can I just keep benchmark change ?

Yes, but I'd do it as a separate benchmark, so we don't need to have benchmarks for:

noColors: true, format: 'italic',
noColors: true, format: 'underline',
noColors: true, format: 'read',

As they will all be the same. So, adding it as a separate benchmark makes more sense.

[RafaelGSS]

Please, create a different file instead. style-text-nocolor.js

[AugustinMauroy]

oh okay got it !