test: fix executable flags #58250
Merged
test: fix executable flags #58250
+0
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiviaMedeiros
added
test
|
Fast-track has been requested by @LiviaMedeiros. Please 👍 to approve. |
cjihrig
approved these changes
May 9, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58250 +/- ##
==========================================
+ Coverage 90.12% 90.19% +0.07%
==========================================
Files 629 629
Lines 186638 186657 +19
Branches 36618 36656 +38
==========================================
+ Hits 168202 168350 +148
+ Misses 11222 11112 -110
+ Partials 7214 7195 -19 🚀 New features to boost your workflow:
|
lpinca
approved these changes
May 9, 2025
anonrig
approved these changes
May 10, 2025
LiviaMedeiros
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in dc7ec42 |
targos
pushed a commit
that referenced
this pull request
May 16, 2025
PR-URL: #58250 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test/parallel/test-http2-server-timeout.jswas added with executable flag in http2: Introducing http/2 #14239test/fixtures/rc/non-readable/node.config.jsonis used bytest/parallel/test-config-file.jswhich chmods this file as executable after successful run. sqlite: add build option to build without sqlite #58122 changed perms to644and after that running this test makes indexable change in the repo.