http2: remove support for priority signaling

[mcollina]

This supersedes #57269 as it also patches some failing test that caught a breaking change in nghttp2.

Technically, this is a breaking change for us, but I ask the @nodejs/tsc to land it in v24.x, as it would massively simplify long-term maintenance of the v24.x line.

[nodejs-github-bot]

Review requested:

• @nodejs/http
• @nodejs/http2
• @nodejs/net
• @nodejs/security-wg

[mcollina]

cc @nodejs/tsc

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.22%. Comparing base (968e2f4) to head (b3e21c0).
Report is 18 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #58293   +/-   ##
=======================================
  Coverage   90.21%   90.22%           
=======================================
  Files         635      635           
  Lines      187580   187565   -15     
  Branches    36853    36848    -5     
=======================================
+ Hits       169231   169236    +5     
+ Misses      11108    11102    -6     
+ Partials     7241     7227   -14     

Files with missing lines	Coverage Δ
lib/internal/http2/core.js	95.13% <100.00%> (-0.43%)	⬇️
lib/internal/util.js	96.25% <100.00%> (-0.06%)	⬇️

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66773/

[lpinca]

There is a typo in the second commit title: priotity -> priority.

[mhdawson]

LGTM

[aduh95]

Blocked on #58313

[aduh95]

I realized there were a few missing mentions in the docs, opened #58504 which should land before this one.

[RafaelGSS]

LGTM. Let's start a CITGM before landing this on v24.x.

[aduh95]

I've removed the nghttp2 update from this PR since it won't be semver-major once this has landed. The first commit is from #58504, to be removed from this PR once the other PR has landed on main.

[aduh95]

CITGM(main): https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3600/
CITGM(this PR): https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3601/

ncu-ci citgm 3600 3601

FAILURE: 2 failures in 3601 not present in 3600


┌──────────────────────────┬──────────────────────┐
│ (index)                  │ 0                    │
├──────────────────────────┼──────────────────────┤
│ ubuntu2204-64            │                      │
│ debian12-x64             │                      │
│ alpine-latest-x64        │                      │
│ rhel9-s390x              │ 'underscore-v1.13.7' │
│ osx13-x64                │                      │
│ rhel9-ppc64le            │                      │
│ win-vs2022_clang         │                      │
│ aix72-ppc64              │ 'browserify-v17.0.1' │
│ fedora-latest-x64        │                      │
│ win11-vs2022_clang-arm64 │                      │
└──────────────────────────┴──────────────────────┘

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/67200/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/67201/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/67234/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/67249/

[nodejs-github-bot]

Landed in a631264