typings: remove blob extra typings #58305
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
approved these changes
May 13, 2025
dario-piotrowicz
added
author ready
github-actions
bot
removed
the
request-ci
legendecas
approved these changes
May 22, 2025
legendecas
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/58305 ✔ Done loading data for nodejs/node/pull/58305 ----------------------------------- PR info ------------------------------------ Title typings: remove blob extra typings (#58305) Author Dario Piotrowicz <[email protected]> (@dario-piotrowicz) Branch dario-piotrowicz:dario/remove-blob-extra-typings -> nodejs:main Labels author ready, typings Commits 2 - typings: remove no longer valid `revokeDataObject` type - typings: remove no longer valid `FixedSizeBlobCopyJob` type Committers 1 - Dario Piotrowicz <[email protected]> PR-URL: https://github.com/nodejs/node/pull/58305 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/58305 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 13 May 2025 00:28:04 GMT ✔ Approvals: 2 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/58305#pullrequestreview-2834988365 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/58305#pullrequestreview-2860436676 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 58305 From https://github.com/nodejs/node * branch refs/pull/58305/merge -> FETCH_HEAD ✔ Fetched commits as 53944c44629b..39a3150f6ef2 -------------------------------------------------------------------------------- [main e6eedf4641] typings: remove no longer valid `revokeDataObject` type Author: Dario Piotrowicz <[email protected]> Date: Tue May 13 01:16:06 2025 +0100 1 file changed, 1 deletion(-) [main 930e4c000c] typings: remove no longer valid `FixedSizeBlobCopyJob` type Author: Dario Piotrowicz <[email protected]> Date: Tue May 13 01:20:44 2025 +0100 1 file changed, 7 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4) Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- typings: remove no longer valid `revokeDataObject` typehttps://github.com/nodejs/node/actions/runs/15182942431 |
dario-piotrowicz
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 53944c4...06fb007 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
May 22, 2025
PR-URL: #58305 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
nodejs-github-bot
pushed a commit
that referenced
this pull request
May 22, 2025
PR-URL: #58305 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is removing two types present in the
blob.d.tsfile that I believe are no longer valid since their C++ implementations have been removed:revokeDataObjectwhich implementation was removed in url: reduce revokeObjectURL cpp calls #47728FixedSizeBlobCopyJobwhich implementation was removed in src: implement DataQueue and non-memory resident Blob #45258