Skip to content

Conversation

JonasBa
Copy link
Contributor

@JonasBa JonasBa commented May 16, 2025

Fixes #57410

@JonasBa JonasBa added doc Issues and PRs related to the documentations. notable-change PRs with changes that should be highlighted in changelogs. fast-track PRs that do not need to wait for 48 hours to land. labels May 16, 2025
Copy link
Contributor

Fast-track has been requested by @JonasBa. Please 👍 to approve.

Copy link
Contributor

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @JonasBa.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label May 16, 2025
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@anonrig
Copy link
Member

anonrig commented May 16, 2025

cc @nodejs/build it seems updating mailmap file requires "test-linux" github actions to pass.

@JonasBa
Copy link
Contributor Author

JonasBa commented May 16, 2025

cc @nodejs/build it seems updating mailmap file requires "test-linux" github actions to pass.

Seems like we already ignore this in test-macos, but not in test-linux. I've went ahead and ported the change in #58356

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label May 16, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 16, 2025
@nodejs-github-bot nodejs-github-bot merged commit e1ab0d1 into nodejs:main May 16, 2025
35 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in e1ab0d1

aduh95 pushed a commit that referenced this pull request May 20, 2025
Fixes: #57410
PR-URL: #58355
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
nodejs-github-bot added a commit that referenced this pull request May 20, 2025
Notable changes:

doc:
  * add JonasBa to collaborators (Jonas Badalic) #58355
  * add puskin to collaborators (Giovanni Bucci) #58308
fs:
  * (SEMVER-MINOR) add to `Dir` support for explicit resource management (Antoine du Hamel) #58206
test_runner:
  * Revert "test_runner: change ts default glob (Théo LUDWIG) #58202

PR-URL: #58406
aduh95 pushed a commit that referenced this pull request May 21, 2025
Notable changes:

doc:
  * add JonasBa to collaborators (Jonas Badalic) #58355
  * add puskin to collaborators (Giovanni Bucci) #58308
fs:
  * (SEMVER-MINOR) add to `Dir` support for explicit resource management (Antoine du Hamel) #58206
test_runner:
  * Revert "test_runner: change ts default glob (Théo LUDWIG) #58202

PR-URL: #58406
aduh95 pushed a commit that referenced this pull request Jun 10, 2025
Fixes: #57410
PR-URL: #58355
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
nodejs-github-bot added a commit that referenced this pull request Jun 10, 2025
Notable changes:

assert:
  * (SEMVER-MINOR) mark partialDeepStrictEqual() as stable (Ruben Bridgewater) #57370
doc:
  * deprecate passing an empty string to `options.shell` (Antoine du Hamel) #58564
  * deprecate HTTP/2 priority signaling (Matteo Collina) #58313
  * add Filip Skokan to TSC (Rafael Gonzaga) #58499
  * add JonasBa to collaborators (Jonas Badalic) #58355
  * add puskin to collaborators (Giovanni Bucci) #58308
  * mark multiple APIs stable (James M Snell) #57513
fs:
  * (SEMVER-MINOR) add autoClose option to FileHandle readableWebStream (James M Snell) #58548
  * (SEMVER-MINOR) add to `Dir` support for explicit resource management (Antoine du Hamel) #58206
http:
  * deprecate instantiating classes without new (Yagiz Nizipli) #58518
http2:
  * (SEMVER-MINOR) add diagnostics channel 'http2.server.stream.finish' (Darshan Sen) #58560
lib:
  * (SEMVER-MINOR) graduate error codes that have been around for years (James M Snell) #58541
src,permission:
  * implicit allow-fs-read to app entrypoint (Rafael Gonzaga) #58579
util:
  * (SEMVER-MINOR) add 'none' style to styleText (James M Snell) #58437

PR-URL: #58665
aduh95 pushed a commit that referenced this pull request Jun 23, 2025
Notable changes:

assert:
  * (SEMVER-MINOR) mark `partialDeepStrictEqual()` as stable (Ruben Bridgewater) #57370
doc:
  * deprecate instantiating `node:http` classes without new (Yagiz Nizipli) #58518
  * deprecate passing an empty string to `options.shell` (Antoine du Hamel) #58564
  * deprecate HTTP/2 priority signaling (Matteo Collina) #58313
  * add Filip Skokan to TSC (Rafael Gonzaga) #58499
  * add JonasBa to collaborators (Jonas Badalic) #58355
  * add puskin to collaborators (Giovanni Bucci) #58308
  * mark multiple APIs stable (James M Snell) #57513
fs:
  * (SEMVER-MINOR) add `autoClose` option to `FileHandle` `readableWebStream` (James M Snell) #58548
  * (SEMVER-MINOR) add to `Dir` support for explicit resource management (Antoine du Hamel) #58206
http2:
  * (SEMVER-MINOR) add diagnostics channel `http2.server.stream.finish` (Darshan Sen) #58560
lib:
  * (SEMVER-MINOR) graduate error codes that have been around for years (James M Snell) #58541
src,permission:
  * implicit `allow-fs-read` to app entrypoint (Rafael Gonzaga) #58579
util:
  * (SEMVER-MINOR) add `'none'` style to styleText (James M Snell) #58437

PR-URL: #58665
aduh95 pushed a commit that referenced this pull request Jun 25, 2025
Notable changes:

assert:
  * (SEMVER-MINOR) mark `partialDeepStrictEqual()` as stable (Ruben Bridgewater) #57370
doc:
  * deprecate instantiating `node:http` classes without new (Yagiz Nizipli) #58518
  * deprecate passing an empty string to `options.shell` (Antoine du Hamel) #58564
  * deprecate HTTP/2 priority signaling (Matteo Collina) #58313
  * add Filip Skokan to TSC (Rafael Gonzaga) #58499
  * add JonasBa to collaborators (Jonas Badalic) #58355
  * add puskin to collaborators (Giovanni Bucci) #58308
  * mark multiple APIs stable (James M Snell) #57513
fs:
  * (SEMVER-MINOR) add `autoClose` option to `FileHandle` `readableWebStream` (James M Snell) #58548
  * (SEMVER-MINOR) add to `Dir` support for explicit resource management (Antoine du Hamel) #58206
http2:
  * (SEMVER-MINOR) add diagnostics channel `http2.server.stream.finish` (Darshan Sen) #58560
lib:
  * (SEMVER-MINOR) graduate error codes that have been around for years (James M Snell) #58541
src,permission:
  * implicit `allow-fs-read` to app entrypoint (Rafael Gonzaga) #58579
util:
  * (SEMVER-MINOR) add `'none'` style to styleText (James M Snell) #58437

PR-URL: #58665
marco-ippolito pushed a commit that referenced this pull request Aug 20, 2025
Fixes: #57410
PR-URL: #58355
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
marco-ippolito added a commit that referenced this pull request Aug 20, 2025
Notable changes:

doc:
  * add JonasBa to collaborators (Jonas Badalic) #58355
  * add puskin to collaborators (Giovanni Bucci) #58308
  * add Filip Skokan to TSC (Rafael Gonzaga) #58499
  * add @geeksilva97 to collaborators (Edy Silva) #57241

PR-URL: TODO
marco-ippolito added a commit that referenced this pull request Aug 20, 2025
Notable changes:

doc:
  * add JonasBa to collaborators (Jonas Badalic) #58355
  * add puskin to collaborators (Giovanni Bucci) #58308
  * add Filip Skokan to TSC (Rafael Gonzaga) #58499
  * add @geeksilva97 to collaborators (Edy Silva) #57241

PR-URL: #59551
marco-ippolito pushed a commit that referenced this pull request Aug 20, 2025
Fixes: #57410
PR-URL: #58355
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
marco-ippolito added a commit that referenced this pull request Aug 20, 2025
Notable changes:

doc:
  * add JonasBa to collaborators (Jonas Badalic) #58355
  * add puskin to collaborators (Giovanni Bucci) #58308
  * add Filip Skokan to TSC (Rafael Gonzaga) #58499
  * add @geeksilva97 to collaborators (Edy Silva) #57241

PR-URL: #59551
marco-ippolito added a commit that referenced this pull request Aug 20, 2025
Notable changes:

doc:
  * add JonasBa to collaborators (Jonas Badalic) #58355
  * add puskin to collaborators (Giovanni Bucci) #58308
  * add Filip Skokan to TSC (Rafael Gonzaga) #58499
  * add geeksilva97 to collaborators (Edy Silva) #57241

PR-URL: #59551
marco-ippolito pushed a commit that referenced this pull request Aug 23, 2025
Fixes: #57410
PR-URL: #58355
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
marco-ippolito added a commit that referenced this pull request Aug 23, 2025
Notable changes:

doc:
  * add JonasBa to collaborators (Jonas Badalic) #58355
  * add puskin to collaborators (Giovanni Bucci) #58308
  * add Filip Skokan to TSC (Rafael Gonzaga) #58499
  * add geeksilva97 to collaborators (Edy Silva) #57241

PR-URL: #59551
marco-ippolito pushed a commit that referenced this pull request Aug 25, 2025
Fixes: #57410
PR-URL: #58355
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
marco-ippolito added a commit that referenced this pull request Aug 25, 2025
Notable changes:

doc:
  * add JonasBa to collaborators (Jonas Badalic) #58355
  * add puskin to collaborators (Giovanni Bucci) #58308
  * add Filip Skokan to TSC (Rafael Gonzaga) #58499
  * add geeksilva97 to collaborators (Edy Silva) #57241

PR-URL: #59551
marco-ippolito pushed a commit that referenced this pull request Aug 25, 2025
Fixes: #57410
PR-URL: #58355
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
marco-ippolito added a commit that referenced this pull request Aug 25, 2025
Notable changes:

doc:
  * add JonasBa to collaborators (Jonas Badalic) #58355
  * add puskin to collaborators (Giovanni Bucci) #58308
  * add Filip Skokan to TSC (Rafael Gonzaga) #58499
  * add geeksilva97 to collaborators (Edy Silva) #57241

PR-URL: #59551
marco-ippolito pushed a commit that referenced this pull request Aug 25, 2025
Fixes: #57410
PR-URL: #58355
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
marco-ippolito added a commit that referenced this pull request Aug 25, 2025
Notable changes:

doc:
  * add JonasBa to collaborators (Jonas Badalic) #58355
  * add puskin to collaborators (Giovanni Bucci) #58308
  * add Filip Skokan to TSC (Rafael Gonzaga) #58499
  * add geeksilva97 to collaborators (Edy Silva) #57241

PR-URL: #59551
marco-ippolito pushed a commit that referenced this pull request Aug 25, 2025
Fixes: #57410
PR-URL: #58355
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
marco-ippolito added a commit that referenced this pull request Aug 25, 2025
Notable changes:

doc:
  * add JonasBa to collaborators (Jonas Badalic) #58355
  * add puskin to collaborators (Giovanni Bucci) #58308
  * add Filip Skokan to TSC (Rafael Gonzaga) #58499
  * add geeksilva97 to collaborators (Edy Silva) #57241

PR-URL: #59551
marco-ippolito pushed a commit that referenced this pull request Aug 26, 2025
Fixes: #57410
PR-URL: #58355
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
marco-ippolito added a commit that referenced this pull request Aug 26, 2025
Notable changes:

doc:
  * add JonasBa to collaborators (Jonas Badalic) #58355
  * add puskin to collaborators (Giovanni Bucci) #58308
  * add Filip Skokan to TSC (Rafael Gonzaga) #58499
  * add geeksilva97 to collaborators (Edy Silva) #57241

PR-URL: #59551
marco-ippolito added a commit that referenced this pull request Aug 26, 2025
Notable changes:

doc:
  * add JonasBa to collaborators (Jonas Badalic) #58355
  * add puskin to collaborators (Giovanni Bucci) #58308
  * add Filip Skokan to TSC (Rafael Gonzaga) #58499
  * add geeksilva97 to collaborators (Edy Silva) #57241

PR-URL: #59551
marco-ippolito added a commit that referenced this pull request Aug 27, 2025
Notable changes:

doc:
  * add JonasBa to collaborators (Jonas Badalic) #58355
  * add puskin to collaborators (Giovanni Bucci) #58308
  * add Filip Skokan to TSC (Rafael Gonzaga) #58499
  * add geeksilva97 to collaborators (Edy Silva) #57241

PR-URL: #59551
marco-ippolito added a commit that referenced this pull request Aug 27, 2025
Notable changes:

doc:
  * add JonasBa to collaborators (Jonas Badalic) #58355
  * add puskin to collaborators (Giovanni Bucci) #58308
  * add Filip Skokan to TSC (Rafael Gonzaga) #58499
  * add geeksilva97 to collaborators (Edy Silva) #57241

PR-URL: #59551
marco-ippolito pushed a commit that referenced this pull request Aug 27, 2025
Fixes: #57410
PR-URL: #58355
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
marco-ippolito added a commit that referenced this pull request Aug 27, 2025
Notable changes:

doc:
  * add JonasBa to collaborators (Jonas Badalic) #58355
  * add puskin to collaborators (Giovanni Bucci) #58308
  * add Filip Skokan to TSC (Rafael Gonzaga) #58499
  * add geeksilva97 to collaborators (Edy Silva) #57241

PR-URL: #59551
marco-ippolito added a commit that referenced this pull request Sep 2, 2025
Notable changes:

doc:
  * add JonasBa to collaborators (Jonas Badalic) #58355
  * add puskin to collaborators (Giovanni Bucci) #58308
  * add Filip Skokan to TSC (Rafael Gonzaga) #58499
  * add geeksilva97 to collaborators (Edy Silva) #57241

PR-URL: #59551
marco-ippolito added a commit that referenced this pull request Sep 2, 2025
Notable changes:

doc:
  * add JonasBa to collaborators (Jonas Badalic) #58355
  * add puskin to collaborators (Giovanni Bucci) #58308
  * add Filip Skokan to TSC (Rafael Gonzaga) #58499
  * add geeksilva97 to collaborators (Edy Silva) #57241

PR-URL: #59551
marco-ippolito added a commit that referenced this pull request Sep 3, 2025
Notable changes:

doc:
  * add JonasBa to collaborators (Jonas Badalic) #58355
  * add puskin to collaborators (Giovanni Bucci) #58308
  * add Filip Skokan to TSC (Rafael Gonzaga) #58499
  * add geeksilva97 to collaborators (Edy Silva) #57241

PR-URL: #59551
marco-ippolito added a commit that referenced this pull request Sep 3, 2025
Notable changes:

doc:
  * add JonasBa to collaborators (Jonas Badalic) #58355
  * add puskin to collaborators (Giovanni Bucci) #58308
  * add Filip Skokan to TSC (Rafael Gonzaga) #58499
  * add geeksilva97 to collaborators (Edy Silva) #57241

PR-URL: #59551
marco-ippolito added a commit that referenced this pull request Sep 3, 2025
Notable changes:

doc:
  * add JonasBa to collaborators (Jonas Badalic) #58355
  * add puskin to collaborators (Giovanni Bucci) #58308
  * add Filip Skokan to TSC (Rafael Gonzaga) #58499
  * add geeksilva97 to collaborators (Edy Silva) #57241

PR-URL: #59551
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project. notable-change PRs with changes that should be highlighted in changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nominating @jonasba to be a collaborator