src: remove node.h APIs to make callback without an async context

[legendecas]

These APIs have been deprecated in #18632.

Given the parameter async_context is essential for stable API AsyncLocalStorage, it'd be better to remove them now.

[jasnell]

7+ years is likely a long enough deprecation cycle ;-)

[jasnell]

This needs to update the corresponding entries in deprecations.md also. Deprecation code DEP0097 I believe.

[legendecas]

This needs to update the corresponding entries in deprecations.md also. Deprecation code DEP0097 I believe.

DEP0097 is a runtime warning and is still possible with the alternative API:

node/test/addons/make-callback-domain-warning/binding.cc

Lines 22 to 23 in a430ef5

	node::MakeCallback(isolate, recv, method, 0, nullptr,
	node::async_context{0, 0});

. So DEP0097 should still be active until we can fully deprecate domain. Or it can be deprecated in a separate PR, as it changes runtime warning -- while this PR is a fully build time deprecation.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.20%. Comparing base (83052ff) to head (3dcca4c).
Report is 80 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #58471      +/-   ##
==========================================
- Coverage   90.22%   90.20%   -0.02%     
==========================================
  Files         635      635              
  Lines      187313   187295      -18     
  Branches    36778    36782       +4     
==========================================
- Hits       169003   168953      -50     
- Misses      11080    11126      +46     
+ Partials     7230     7216      -14     

Files with missing lines	Coverage Δ
src/api/callback.cc	82.29% <ø> (+7.05%)	⬆️
src/node.h	92.30% <ø> (ø)

... and 48 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[addaleax]

I think this one you'll want to run CITGM for. This is probably still a fairly popular thing to use in extant Node.js addons.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/67154/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/67165/

[legendecas]

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3599/

No failures related to MakeCallback removal.

[nodejs-github-bot]

Landed in 708fd19